Skip to content

[ObsUX][Infra] Fix broken storybook stories #218090

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Apr 18, 2025

Conversation

rmyz
Copy link
Contributor

@rmyz rmyz commented Apr 14, 2025

Summary

Closes #218063

This PR fixes the broken storybook stories we have for Infra.

@rmyz rmyz added release_note:skip Skip the PR/issue when compiling release notes backport:skip This commit does not require backporting Team:obs-ux-infra_services Observability Infrastructure & Services User Experience Team labels Apr 14, 2025
@rmyz rmyz self-assigned this Apr 14, 2025
@rmyz rmyz changed the title fix: fix some stories [ObsUX][Infra] Fix broken storybook stories Apr 14, 2025
@@ -107,7 +107,3 @@ export const CustomEquationEditorWithEquationErrors = {
},
},
};

export const CustomEquationEditorWithFieldError = {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is no point on having this story since we don't use field error, that's why it was removed

@rmyz rmyz marked this pull request as ready for review April 15, 2025 13:30
@rmyz rmyz requested review from a team as code owners April 15, 2025 13:30
@elasticmachine
Copy link
Contributor

Pinging @elastic/obs-ux-infra_services-team (Team:obs-ux-infra_services)

Copy link
Contributor

@MiriamAparicio MiriamAparicio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review LGTM

Copy link
Contributor

@achyutjhunjhunwala achyutjhunjhunwala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@jennypavlova jennypavlova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM 💯

@@ -88,7 +88,7 @@ const AlertDetailsAppSection = ({ rule, alert }: AlertDetailsAppSectionProps) =>
</EuiFlexItem>
</EuiFlexGroup>
<EuiFlexGroup>
<EuiFlexItem style={{ maxHeight: 120 }} grow={1}>
<EuiFlexItem css={{ maxHeight: 120 }} grow={1}>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 👍

Copy link
Contributor

@justinkambic justinkambic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rmyz rmyz enabled auto-merge (squash) April 18, 2025 15:08
@rmyz rmyz merged commit 36c495c into elastic:main Apr 18, 2025
10 checks passed
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
infra 1.2MB 1.2MB +60.0B

History

cc @rmyz

davismcphee pushed a commit to davismcphee/kibana that referenced this pull request Apr 22, 2025
## Summary

Closes elastic#218063

This PR fixes the broken storybook stories we have for Infra.

---------

Co-authored-by: kibanamachine <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:obs-ux-infra_services Observability Infrastructure & Services User Experience Team v9.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Infra] Review broken storybook stories
7 participants