-
Notifications
You must be signed in to change notification settings - Fork 8.3k
[ObsUX][Infra] Fix broken storybook stories #218090
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@@ -107,7 +107,3 @@ export const CustomEquationEditorWithEquationErrors = { | |||
}, | |||
}, | |||
}; | |||
|
|||
export const CustomEquationEditorWithFieldError = { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is no point on having this story since we don't use field error, that's why it was removed
Pinging @elastic/obs-ux-infra_services-team (Team:obs-ux-infra_services) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code review LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code LGTM 💯
@@ -88,7 +88,7 @@ const AlertDetailsAppSection = ({ rule, alert }: AlertDetailsAppSectionProps) => | |||
</EuiFlexItem> | |||
</EuiFlexGroup> | |||
<EuiFlexGroup> | |||
<EuiFlexItem style={{ maxHeight: 120 }} grow={1}> | |||
<EuiFlexItem css={{ maxHeight: 120 }} grow={1}> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
💚 Build Succeeded
Metrics [docs]Async chunks
History
cc @rmyz |
## Summary Closes elastic#218063 This PR fixes the broken storybook stories we have for Infra. --------- Co-authored-by: kibanamachine <[email protected]>
Summary
Closes #218063
This PR fixes the broken storybook stories we have for Infra.