-
Notifications
You must be signed in to change notification settings - Fork 850
[Visual Refresh][EuiButton] Add Refresh design update #1 #8595
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
mgadewoll
wants to merge
11
commits into
elastic:feat/button-visual-refresh
Choose a base branch
from
mgadewoll:button/280-visual-refresh-part-1
base: feat/button-visual-refresh
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
[Visual Refresh][EuiButton] Add Refresh design update #1 #8595
mgadewoll
wants to merge
11
commits into
elastic:feat/button-visual-refresh
from
mgadewoll:button/280-visual-refresh-part-1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
452a7b0
to
e213698
Compare
e213698
to
075cc28
Compare
💚 Build SucceededHistorycc @mgadewoll |
Preview staging links for this PR:
|
💚 Build Succeeded
History
cc @mgadewoll |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Implements https://github.com/elastic/eui-private/issues/280
Important
This PR merged into a feature branch.
This is to allow for a more scoped review on parts of the updates as well as providing time for visual reviews before merging to main.
This PR adds the first part to implement the new button design. (figma)
Changes
buttonVariant
to enable toggling betweenrefresh
andclassic
design variantsEuiProvider
to support rebuilding the theme on themeflags
changeisEuiThemeRefreshVariant
anduseEuiThemeRefreshVariant
to enable in-code feature flaggingbackgroundLightText
token value fromshade130
toshade120
_button.ts
Note
Focus style changes are not included. Those will be handled as standalone update (https://github.com/elastic/eui-private/issues/267).
Note
This PR only updates base button components. Related components like
EuiButtonGroup
orEuiFilterGroup
etc will be updated in a separate PR.Screenshots
ℹ️ Left: new; Right: previous
EuiButton
(primary)Screen.Recording.2025-04-15.at.10.22.00.mov
EuiButton
(text)Screen.Recording.2025-04-15.at.10.22.24.mov
EuiButton
(primary)Screen.Recording.2025-04-15.at.10.22.57.mov
EuiButtonEmpty
Screen.Recording.2025-04-15.at.10.24.27.mov
EuiButtonEmpty
Screen.Recording.2025-04-15.at.10.28.22.mov
EuiButtonIcon
Screen.Recording.2025-04-15.at.10.27.19.mov
EuiButtonIcon
Screen.Recording.2025-04-15.at.10.27.44.mov
EuiButtonIcon
Screen.Recording.2025-04-15.at.10.27.33.mov
QA
ℹ️ Provided testing stories that display "refresh" and "classic" design variants next to each other:
EuiButton
EuiButtonEmpty
EuiButtonIcon
(ℹ️ provided test stories have both "refresh" and "classic" variants displayed for easier review)
General checklist
Checked in mobileAdded documentationProps have proper autodocs (using@default
if default values are missing) and playground togglesChecked Code Sandbox works for any docs examplesAdded or updated jest and cypress testsIf applicable, added the breaking change issue label (and filled out the breaking change checklist)If applicable, file an issue to update EUI's Figma library with any corresponding UI changes. (This is an internal repo, if you are external to Elastic, ask a maintainer to submit this request)