Skip to content

Increase http.max_header_size default to 16kb #88725

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jul 25, 2022
Merged

Increase http.max_header_size default to 16kb #88725

merged 5 commits into from
Jul 25, 2022

Conversation

n1v0lg
Copy link
Contributor

@n1v0lg n1v0lg commented Jul 22, 2022 •
edited
Loading

Our current default for the http.max_header_size setting is 8kb. This
is lower than the current default for Kibana (16kb in 8.x), and the ESS
proxy (1mb based on the Go http library default). To align with the
current convention of other Elastic components, this PR increases the
ES header size setting default to 16kb.

Closes #88501

@n1v0lg n1v0lg added >enhancement :Distributed Coordination/Network Http and internode communication implementations labels Jul 22, 2022
@n1v0lg n1v0lg self-assigned this Jul 22, 2022
@elasticsearchmachine
Copy link
Collaborator

Hi @n1v0lg, I've created a changelog YAML for you.

@n1v0lg n1v0lg marked this pull request as ready for review July 22, 2022 14:57
@n1v0lg n1v0lg requested a review from DaveCTurner July 22, 2022 14:57
@elasticsearchmachine elasticsearchmachine added the Team:Distributed (Obsolete) Meta label for distributed team (obsolete). Replaced by Distributed Indexing/Coordination. label Jul 22, 2022
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-distributed (Team:Distributed)

DaveCTurner
DaveCTurner requested changes Jul 22, 2022
View reviewed changes
Copy link
Contributor

@DaveCTurner DaveCTurner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good but the docs at docs/reference/modules/http.asciidoc still say the default is 8kb.

@n1v0lg
Copy link
Contributor Author

n1v0lg commented Jul 22, 2022

Whoops, good catch!

@n1v0lg n1v0lg requested a review from DaveCTurner July 22, 2022 15:08
DaveCTurner
DaveCTurner approved these changes Jul 22, 2022
View reviewed changes
Copy link
Contributor

@DaveCTurner DaveCTurner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@elasticsearchmachine elasticsearchmachine changed the base branch from master to main July 22, 2022 23:04
@n1v0lg
Copy link
Contributor Author

n1v0lg commented Jul 25, 2022

@elasticmachine run elasticsearch-ci/part-2

@n1v0lg n1v0lg merged commit b04c0f3 into elastic:main Jul 25, 2022
@n1v0lg n1v0lg deleted the increase-max-header-size-default branch July 25, 2022 10:57
This was referenced Apr 22, 2025
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DaveCTurner DaveCTurner DaveCTurner approved these changes

Assignees

@n1v0lg n1v0lg

Labels
:Distributed Coordination/Network Http and internode communication implementations >enhancement Team:Distributed (Obsolete) Meta label for distributed team (obsolete). Replaced by Distributed Indexing/Coordination. v8.4.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Increase http.max_header_size default to 16KB
3 participants
@n1v0lg @elasticsearchmachine @DaveCTurner