SNAPSHOTS: Upgrade GCS Dependencies to 1.55.0 #36634
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
original-brownbear
commented
Dec 14, 2018
original-brownbear
commented
- Closes Increment google cloud apis to 1.52 #35459
- Closes Snapshots on large indices fail on some shards when master election occurs #35229
* Closes elastic#35459 * Closes elastic#35229
original-brownbear
added
>bug
:Distributed Coordination/Snapshot/Restore
|
Pinging @elastic/es-distributed |
| @@ -80,6 +80,11 @@ public Bucket get(String bucket, BucketGetOption... options) { | |||
| } | |||
| } | |||
|
|
|||
| @Override | |||
| public Bucket lockRetentionPolicy(final BucketInfo bucket, final BucketTargetOption... options) { | |||
There was a problem hiding this comment.
API change in the dependency made overriding this necessary.
Since we don't use it yet, I added just a dummy override.
|
@atorok thanks! |
|
I have a follow up question that I mention here. Would someone be able to take a look? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.