-
Notifications
You must be signed in to change notification settings - Fork 988
[docs] Fix various syntax and rendering errors #2378
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change | ||||
---|---|---|---|---|---|---|
|
@@ -7,11 +7,11 @@ navigation_title: Installation | |||||
|
||||||
elasticsearch-hadoop binaries can be obtained either by downloading them from the [elastic.co](http://elastic.co) site as a ZIP (containing project jars, sources and documentation) or by using any [Maven](http://maven.apache.org/)-compatible tool with the following dependency: | ||||||
|
||||||
```xml | ||||||
```xml subs=true | ||||||
<dependency> | ||||||
<groupId>org.elasticsearch</groupId> | ||||||
<artifactId>elasticsearch-hadoop</artifactId> | ||||||
<version>9.0.0-beta1</version> | ||||||
<version>{{version}}</version> | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||
</dependency> | ||||||
``` | ||||||
|
||||||
|
@@ -24,33 +24,33 @@ elasticsearch-hadoop binary is suitable for Hadoop 2.x (also known as YARN) envi | |||||
|
||||||
In addition to the *uber* jar, elasticsearch-hadoop provides minimalistic jars for each integration, tailored for those who use just *one* module (in all other situations the `uber` jar is recommended); the jars are smaller in size and use a dedicated pom, covering only the needed dependencies. These are available under the same `groupId`, using an `artifactId` with the pattern `elasticsearch-hadoop-{{integration}}`: | ||||||
|
||||||
```xml | ||||||
```xml subs=true | ||||||
<dependency> | ||||||
<groupId>org.elasticsearch</groupId> | ||||||
<artifactId>elasticsearch-hadoop-mr</artifactId> <1> | ||||||
<version>9.0.0-beta1</version> | ||||||
<version>{{version}}</version> | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||
</dependency> | ||||||
``` | ||||||
|
||||||
1. *mr* artifact | ||||||
|
||||||
|
||||||
```xml | ||||||
```xml subs=true | ||||||
<dependency> | ||||||
<groupId>org.elasticsearch</groupId> | ||||||
<artifactId>elasticsearch-hadoop-hive</artifactId> <1> | ||||||
<version>9.0.0-beta1</version> | ||||||
<version>{{version}}</version> | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||
</dependency> | ||||||
``` | ||||||
|
||||||
1. *hive* artifact | ||||||
|
||||||
|
||||||
```xml | ||||||
```xml subs=true | ||||||
<dependency> | ||||||
<groupId>org.elasticsearch</groupId> | ||||||
<artifactId>elasticsearch-spark-30_2.12</artifactId> <1> | ||||||
<version>9.0.0-beta1</version> | ||||||
<version>{{version}}</version> | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||
</dependency> | ||||||
``` | ||||||
|
||||||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IMO we will likely need to be more specific, per discussions in elastic/docs-builder#737
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was intended to be a temporary solution until elastic/docs-builder#737 is addressed and there's a central place to manage versions.
I had to add
version
subs to multiple repos in related PRs. I'm not planning to go back and update all other repos unless elastic/docs-builder#737 can't be addressed before the next release, but you're welcome to make this change in this repo (and any other repos) if you think that would be better.