Add support for Spark 3.0 #1592
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… to changes in Spark 3
|
Known issue with Spark 3.0 #1593 |
|
@jbaiera I was able to build your branch, with JDK 11 although I had to export |
|
@jbaiera I was able to build you branch as well - using JDK 11 although I had to export JAVA8_HOME to my JDK8 dir. I have tested this writing a few tables to elastic - one with ~ 9 million rows - using "WAN" setting as I am indexing into a hosted cluster. I have had no issues this far |
danhermann
approved these changes
Feb 15, 2021
There was a problem hiding this comment.
LGTM. I've walked through the code with @jbaiera and done some basic testing both reading from and writing to ES in Spark3.
jbaiera
added a commit
to jbaiera/elasticsearch-hadoop
that referenced
this pull request
Feb 16, 2021
Spark 3.0 support is added via a new source directory and subproject. Supported Scala versions are only 2.12.
jbaiera
added a commit
that referenced
this pull request
Feb 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for Spark version 3.0.
Closes #1412
Reviewer's note: The PR is best reviewed by evaluating the changes on each commit, since 6c0b177 is just a source copy operation from the Spark 2.x project.