Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: missing response body with guzzle psr7 streams #30

Merged
merged 1 commit into from
Apr 1, 2025

Conversation

shyim
Copy link
Contributor

@shyim shyim commented Sep 8, 2024

Because you cast the body to string, it triggers https://github.com/guzzle/psr7/blob/2.7/src/Stream.php#L84

and therefore the Guzzle Stream has been read to the end, and a getContents afterwards always returns an empty string

Copy link

cla-checker-service bot commented Sep 8, 2024

💚 CLA has been signed

@shyim
Copy link
Contributor Author

shyim commented Sep 8, 2024

I did sign

@ezimuel ezimuel self-requested a review April 1, 2025 13:10
Copy link
Contributor

@ezimuel ezimuel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@ezimuel ezimuel merged commit bcbdc86 into elastic:main Apr 1, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants