Refactor user change on service #8347
Open
+888
−159
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michalpristas
added
Team:Elastic-Agent-Control-Plane
|
Pinging @elastic/elastic-agent-control-plane (Team:Elastic-Agent-Control-Plane) |
pchila
reviewed
Jun 5, 2025
|
|
||
| // isSystemdRunning checks if systemd is the init system and is running | ||
| func isSystemdRunning() bool { | ||
| // Check if systemd is PID 1 |
There was a problem hiding this comment.
Please update comment since what we are doing here is implement the same check as sd_booted()
There was a problem hiding this comment.
i don't follow, please be explicit
|
💔 Build Failed
Failed CI Steps
History
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactor the way how we do User change during
unprivilegedandprivilegedactions.Pre-PR we removed and reinstalled service again with new user setup.
Post-PR we rewrite service file directly (linux and darwin) or use syscall to change config (windows). Then we restart service.
This reduces window for interrupt.
While pre-PR could leave us without a service, in this case we haven't won entirely. We can end up with broken service when service manager decides config/user is not valid/enabled. This at least leaves a trace in system logs.
Tests covering switch between privilege modes are already present
Closes: #8268