Skip to content

use relevant evidence fields for cis_gcp 2.13 #3240

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

orouz
Copy link
Collaborator

@orouz orouz commented Apr 27, 2025

Summary of your changes

  1. rule evaluation didn't change, just refactored
  2. the evidence field returned for the failed case is the list of enabled service usage assets (which assets inventory was not part of), and for the passed case it's the service usage assets indicating assets inventory is enabled
  3. assets returned in the evidence field only contain the resource.data fields which are relevant for identification and were used in evaluation

Screenshot/Data

before after
shows list of full service usage assets as evidence Screenshot 2025-04-27 at 15 22 58 shows list of assets inventory trimmed service usage assets as evidenceScreenshot 2025-04-27 at 16 03 50

Related Issues

@mergify mergify bot assigned orouz Apr 27, 2025
Copy link

mergify bot commented Apr 27, 2025

This pull request does not have a backport label. Could you fix it @orouz? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-v./d./d./d is the label to automatically backport to the 8./d branch. /d is the digit
  • backport-active-all is the label that automatically backports to all active branches.
  • backport-active-8 is the label that automatically backports to all active minor branches for the 8 major.
  • backport-active-9 is the label that automatically backports to all active minor branches for the 9 major.

@orouz orouz marked this pull request as ready for review April 27, 2025 15:34
@orouz orouz requested a review from a team as a code owner April 27, 2025 15:34
Copy link
Contributor

@eyalkraft eyalkraft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, please test with a failed finding as well (by changing the actual cloud config)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants