Skip to content

[Assets Inventory] Add network asset #3019

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Feb 27, 2025
Merged

[Assets Inventory] Add network asset #3019

merged 3 commits into from
Feb 27, 2025

Conversation

orouz
Copy link
Collaborator

@orouz orouz commented Feb 16, 2025 •
edited
Loading

Summary of your changes

  1. adds GCP VPC Network classification
  2. adds network.name enricher

with this PR, the only asset type remaining for GA is GCP Compute Network Interface which is really a network enricher on the compute.googleapis.com/Instance asset type and will be resolved in #3018

Related Issues

@orouz orouz force-pushed the gcp_network_asset branch from 8e424af to 17244c7 Compare February 16, 2025 07:35
@mergify mergify bot assigned orouz Feb 16, 2025
@mergify Mergify
Copy link

mergify bot commented Feb 16, 2025

This pull request does not have a backport label. Could you fix it @orouz? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-v./d./d./d is the label to automatically backport to the 8./d branch. /d is the digit
  • backport-active-all is the label that automatically backports to all active branches.
  • backport-active-8 is the label that automatically backports to all active minor branches for the 8 major.
  • backport-active-9 is the label that automatically backports to all active minor branches for the 9 major.
    NOTE: backport-v8.x has been added to help with the transition to the new branch 8.x.

@orouz orouz marked this pull request as ready for review February 16, 2025 09:25
@orouz orouz requested a review from a team as a code owner February 16, 2025 09:25
@orouz orouz enabled auto-merge (squash) February 27, 2025 13:40
@orouz orouz merged commit a06f2db into elastic:main Feb 27, 2025
9 checks passed
mergify bot pushed a commit that referenced this pull request Feb 27, 2025
@orouz @mergify
[Assets Inventory] Add network asset (#3019)
f3330d7 
(cherry picked from commit a06f2db)
@mergify mergify bot mentioned this pull request Feb 27, 2025
Merged
orouz pushed a commit that referenced this pull request Feb 27, 2025
@mergify
[8.x](backport #3019) [Assets Inventory] Add network asset (#3062)
67145ad
mergify bot pushed a commit that referenced this pull request Mar 16, 2025
@orouz @mergify
[Assets Inventory] Add network asset (#3019)
b3d256c 
(cherry picked from commit a06f2db)
@mergify mergify bot mentioned this pull request Mar 16, 2025
Merged
orouz pushed a commit that referenced this pull request Mar 17, 2025
@mergify
[9.0](backport #3019) [Assets Inventory] Add network asset (#3101)
d9a821c
@orouz orouz mentioned this pull request Apr 3, 2025
Open
mergify bot pushed a commit that referenced this pull request Apr 15, 2025
@orouz @mergify
[Assets Inventory] Add network asset (#3019)
a8067cf 
(cherry picked from commit a06f2db)

# Conflicts:
#	internal/inventory/gcpfetcher/fetcher_assets.go
#	internal/inventory/gcpfetcher/fetcher_assets_test.go
@mergify mergify bot mentioned this pull request Apr 15, 2025
Merged
orouz added a commit to orouz/cloudbeat that referenced this pull request Apr 16, 2025
@orouz
[Assets Inventory] Add network asset (elastic#3019)
9c63921
orouz pushed a commit that referenced this pull request Apr 16, 2025
@mergify
[8.18](backport #3019) [Assets Inventory] Add network asset (#3193)
6ea76eb
@kubasobon kubasobon mentioned this pull request Apr 16, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kubasobon kubasobon kubasobon approved these changes

Assignees

@orouz orouz

Labels
backport-v8.x backport-v8.18.0 backport-v9.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@orouz @kubasobon