Revert upload artifact version from v4 to v3 #1873
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request does not have a backport label. Could you fix it @gurevichdmitry? 🙏
|
3 tasks
📊 Allure Report - 💚 No failures were reported.
|
oren-zohar
approved these changes
Jan 29, 2024
amirbenun
approved these changes
Jan 29, 2024
orestisfl
reviewed
Jan 29, 2024
| @@ -52,4 +52,5 @@ updates: | |||
| artifact: | |||
| patterns: | |||
| - "actions/download-artifact" | |||
| - "actions/upload-artifact" | |||
| # Skip upload-artifact due to this issue: https://github.com/actions/upload-artifact/issues/478 | |||
| # - "actions/upload-artifact" | |||
There was a problem hiding this comment.
Reverted in this PR and added ignore
| @@ -211,7 +211,7 @@ jobs: | |||
|
|
|||
| - name: Upload Test Results | |||
| if: always() | |||
| uses: actions/upload-artifact@v4 | |||
| uses: actions/upload-artifact@v3 | |||
There was a problem hiding this comment.
Please, also downgrade download-artifact to the same version
There was a problem hiding this comment.
@orestisfl, Opened a new PR to revert the download-artifact action and also updated the dependabot.yaml to ignore 4.x versions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of your changes
The latest version of the upload-artifact action has revealed this issue, causing a break in the k8s CI. As mentioned in this comment, this issue does not occur with actions/upload-artifact@v3. This PR reverts the upload-artifact action version from v4 to v3.
Screenshot/Data
Related Issues
Checklist
Introducing a new rule?