Skip to content

ci(bk package jobs): Don't package arm64 on amd64 workers #43170

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 12, 2025
Merged

ci(bk package jobs): Don't package arm64 on amd64 workers #43170

merged 1 commit into from
Mar 12, 2025

Conversation

v1v
Copy link
Member

@v1v v1v commented Mar 10, 2025 •
edited
Loading

Proposed commit message

It ensures that arm64 packages get built without qemu emulation on dedicated arm64 workers.

#43026 fixed the DRA pipeline, but the CI packaging steps in the BK beats pipelines was not changed.

This should help with some failures we are seeing like:

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Disruptive User Impact

Author's Checklist

  • [ ]

How to test this PR locally

In the CI itself, let's see how it goes

In addition, I cherry-picked the changes and updated #43145, so I expect to see if it works.

Related issues

Use cases

Screenshots

Logs

@v1v v1v added backport-8.x Automated backport to the 8.x branch with mergify backport-8.17 Automated backport with mergify backport-8.18 Automated backport to the 8.18 branch backport-9.0 Automated backport to the 9.0 branch labels Mar 10, 2025
@v1v v1v requested a review from a team as a code owner March 10, 2025 21:27
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Mar 10, 2025
@botelastic
Copy link

botelastic bot commented Mar 10, 2025

This pull request doesn't have a Team:<team> label.

@mergify mergify bot assigned v1v Mar 10, 2025
@v1v v1v marked this pull request as draft March 10, 2025 21:28
@v1v v1v marked this pull request as ready for review March 11, 2025 11:06
dliappis
dliappis approved these changes Mar 12, 2025
View reviewed changes
Copy link
Contributor

@dliappis dliappis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Just be aware of a few pending backports for #43026 to:

that fix the corresponding pieces in the DRA pipeline itself (depending on CI ought to merged very soon)

@v1v v1v requested a review from pazone March 12, 2025 15:24
@v1v
Copy link
Member Author

v1v commented Mar 12, 2025

Just be aware of a few pending backports for #43026 to:

They have just been merged, so I'll wait for another couple of eyes, @pazone , I need your 👁️ , so we play safe here. Thanks

@pazone
Copy link
Contributor

pazone commented Mar 12, 2025

I see that we still build an arm package on an amd64 machine. Is it expected?

@v1v
Copy link
Member Author

v1v commented Mar 12, 2025

I see that we still build an arm package on an amd64 machine. Is it expected?

yes darwin/arm64 is not linux/arm64. Thanks for double checking

pazone
pazone approved these changes Mar 12, 2025
View reviewed changes
Copy link
Contributor

@pazone pazone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, if the darwin arm64 build is intended to be built on an amd64 machine.

@v1v
Copy link
Member Author

v1v commented Mar 12, 2025

LGTM, if the darwin arm64 build is intended to be built on an amd64 machine.

Yes, see what the DRA does here.

@v1v v1v merged commit c80fbe1 into elastic:main Mar 12, 2025
131 checks passed
@v1v v1v changed the title bk(package jobs): Don't package arm64 on amd64 workers ci(bk package jobs): Don't package arm64 on amd64 workers Mar 12, 2025
mergify bot pushed a commit that referenced this pull request Mar 12, 2025
@v1v @mergify
ci(bk package jobs): Don't package arm64 on amd64 workers (#43170)
d261049 
(cherry picked from commit c80fbe1)
mergify bot pushed a commit that referenced this pull request Mar 12, 2025
@v1v @mergify
ci(bk package jobs): Don't package arm64 on amd64 workers (#43170)
a22ceea 
(cherry picked from commit c80fbe1)
This was referenced Mar 12, 2025
Merged
Merged
mergify bot pushed a commit that referenced this pull request Mar 12, 2025
@v1v @mergify
ci(bk package jobs): Don't package arm64 on amd64 workers (#43170)
0b7f285 
(cherry picked from commit c80fbe1)
@mergify mergify bot mentioned this pull request Mar 12, 2025
Merged
6 tasks
mergify bot pushed a commit that referenced this pull request Mar 12, 2025
@v1v @mergify
ci(bk package jobs): Don't package arm64 on amd64 workers (#43170)
64c0685 
(cherry picked from commit c80fbe1)
@mergify mergify bot mentioned this pull request Mar 12, 2025
Merged
6 tasks
@shmsr
Copy link
Member

shmsr commented Mar 12, 2025

@v1v Months back I was working on some improvements to cut time taken by CI. Could you please take a look? If it looks good, then we can add these too?

PR: #41033

Check the buildkite files specifically.

And yeah, good to see this change. I first saw these when I debugging something, observations here: #41087 (comment)

Thanks!

v1v pushed a commit that referenced this pull request Mar 13, 2025
@mergify
ci(bk package jobs): Don't package arm64 on amd64 workers (#43170) (#…
6142516 
…43246)
v1v added a commit that referenced this pull request Mar 13, 2025
@mergify @v1v
ci(bk package jobs): Don't package arm64 on amd64 workers (#43170) (#…
f69b1f2 
…43248)

(cherry picked from commit c80fbe1)

Co-authored-by: Victor Martinez <[email protected]>
v1v added a commit that referenced this pull request Mar 13, 2025
@mergify @v1v
ci(bk package jobs): Don't package arm64 on amd64 workers (#43170) (#…
77d0d93 
…43247)

(cherry picked from commit c80fbe1)

Co-authored-by: Victor Martinez <[email protected]>
v1v added a commit that referenced this pull request Mar 20, 2025
@mergify @v1v
ci(bk package jobs): Don't package arm64 on amd64 workers (#43170) (#…
2200cfb 
…43245)

(cherry picked from commit c80fbe1)

Co-authored-by: Victor Martinez <[email protected]>
@v1v v1v mentioned this pull request Mar 20, 2025
Closed
6 tasks
@pierrehilbert
Copy link
Collaborator

@v1v I think we forgot to backport this one to 8.16

@v1v
Copy link
Member Author

v1v commented Mar 25, 2025 •
edited
Loading

I think we forgot to backport this one to 8.16

Oh dear, do we expect anything in there after the upcoming 8.18 release shortly?

Although, I see https://github.com/elastic/beats/blob/8.16/.go-version so it uses 1.23.6

So I'm not sure whether it's actually using the split:

elastic/golang-crossbuild#560 is actually pending to be merged. So that's the reason. I don't think we need the backport to 8.16 in this case

@v1v v1v added the backport-8.16 Automated backport with mergify label Mar 25, 2025
mergify bot pushed a commit that referenced this pull request Mar 25, 2025
@v1v @mergify
ci(bk package jobs): Don't package arm64 on amd64 workers (#43170)
0dd3caa 
(cherry picked from commit c80fbe1)
@mergify mergify bot mentioned this pull request Mar 25, 2025
Merged
6 tasks
pierrehilbert pushed a commit that referenced this pull request Mar 26, 2025
@mergify @v1v
ci(bk package jobs): Don't package arm64 on amd64 workers (#43170) (#…
b3a3535 
…43484)

(cherry picked from commit c80fbe1)

Co-authored-by: Victor Martinez <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dliappis dliappis dliappis approved these changes

@pazone pazone pazone approved these changes

Assignees

@v1v v1v

Labels
backport-8.x Automated backport to the 8.x branch with mergify backport-8.16 Automated backport with mergify backport-8.17 Automated backport with mergify backport-8.18 Automated backport to the 8.18 branch backport-9.0 Automated backport to the 9.0 branch needs_team Indicates that the issue/PR needs a Team:* label
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@v1v @pazone @shmsr @pierrehilbert @dliappis