Remove release tag from APM package

[jsoriano]

Motivation/summary

release tag has been deprecated elastic/package-spec#225 in favour of semantic versioning.

It can still be used, but incoherent uses between it and prerelease tags in the version are discouraged. The package registry provides a compatibility layer so packages without release continue working with old versions of Fleet. In the API, this tag is filled automatically when not provided in the package.

The APM package is making incoherent use of the release tag and its version, release is always ga, also in prerelease versions.

Checklist

• Update package changelog.yml (only if changes to apmpackage have been made)

How to test these changes

• APM package should continue working.
• Prerelease versions of the APM package should have a prerelease badge in Fleet UI.

Related issues

• Related to [Change Proposal] Remove release tag from packages package-spec#225

[apmmachine]

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS

Expand to view the summary

Build stats

• Start Time: 2022-04-27T13:00:29.412+0000

• Duration: 27 min 31 sec

Test stats 🧪

Test	Results
Failed	0
Passed	3978
Skipped	13
Total	3991

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

• /test : Re-trigger the build.

• /hey-apm : Run the hey-apm benchmark.

• /package : Generate and publish the docker images.

• /test windows : Build & tests on Windows.

• run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

[mergify]

This pull request does not have a backport label. Could you fix it @jsoriano? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

• backport-7.x is the label to automatically backport to the 7.x branch.
• backport-7./d is the label to automatically backport to the 7./d branch. /d is the digit

NOTE: backport-skip has been added to this pull request.

[jsoriano]

@simitt @axw I am finding problems updating elastic-package here. Do you have an idea of what could be happening?
I think this may be related to the specific go.mod in the tools directory. If I move the entries there to the root-level go.mod, elastic-package works.

[mergify]

This pull request is now in conflicts. Could you fix it @jsoriano? 🙏
To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

git fetch upstream
git checkout -b remove-package-release-label upstream/remove-package-release-label
git merge upstream/main
git push upstream remove-package-release-label

[axw]

@jsoriano seems to be a module dependency conflict in tools. That needs to be fixed - we shouldn't have tools in the top level go.mod.

[jsoriano]

@jsoriano seems to be a module dependency conflict in tools. That needs to be fixed - we shouldn't have tools in the top level go.mod.

The problem seems to be in shared kubernetes libraries:

$ go run -modfile=tools/go.mod github.com/elastic/elastic-package version
# k8s.io/client-go/applyconfigurations/meta/v1
../../../../pkg/mod/k8s.io/[email protected]/applyconfigurations/meta/v1/unstructured.go:64:38: cannot use doc (variable of type *"github.com/googleapis/gnostic/openapiv2".Document) as type *"github.com/google/gnostic/openapiv2".Document in argument to proto.NewOpenAPIData
# k8s.io/kubectl/pkg/util/openapi
../../../../pkg/mod/k8s.io/[email protected]/pkg/util/openapi/openapi.go:49:38: cannot use doc (variable of type *"github.com/googleapis/gnostic/openapiv2".Document) as type *"github.com/google/gnostic/openapiv2".Document in argument to proto.NewOpenAPIData

[mergify]

This pull request is now in conflicts. Could you fix it @jsoriano? 🙏
To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

git fetch upstream
git checkout -b remove-package-release-label upstream/remove-package-release-label
git merge upstream/main
git push upstream remove-package-release-label

[mergify]

This pull request is now in conflicts. Could you fix it @jsoriano? 🙏
To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

git fetch upstream
git checkout -b remove-package-release-label upstream/remove-package-release-label
git merge upstream/main
git push upstream remove-package-release-label

[apmmachine]

🌐 Coverage report

Name	Metrics % (covered/total)	Diff
Packages	100.0% (43/43)	💚
Files	91.878% (181/197)	👍
Classes	93.407% (425/455)	👍
Methods	89.283% (1083/1213)	👍
Lines	77.382% (13151/16995)	👍 0.024
Conditionals	100.0% (0/0)	💚

[simitt]

Thanks for your contribution Jaime!