fix: add cacerts to ubi docker image #16928
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the ubi docker image doesn't include cacerts, use the chainguard base image to retrieve them so we can use dependency management to keep them updated
kruskall
added
backport-active-9
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
rubvs
approved these changes
May 15, 2025
carsonip
approved these changes
May 19, 2025
There was a problem hiding this comment.
Q about backporting:
note: 8.x is not affected because it's using the ubuntu image but it seems we're vendoring the cacerts there so there's value in backporting this
Do you expect to remove the vendoring (packaging/docker/cacert.pem) and use chainguard /etc/pki and /etc/ssl instead?
yes |
carsonip
approved these changes
May 19, 2025
|
@Mergifyio backport 8.17 8.18 8.19 9.0 |
✅ Backports have been created
|
mergify bot
pushed a commit
that referenced
this pull request
May 19, 2025
the ubi docker image doesn't include cacerts, use the chainguard base image to retrieve them so we can use dependency management to keep them updated (cherry picked from commit ad627b2) # Conflicts: # packaging/docker/Dockerfile
2 tasks
mergify bot
pushed a commit
that referenced
this pull request
May 19, 2025
the ubi docker image doesn't include cacerts, use the chainguard base image to retrieve them so we can use dependency management to keep them updated (cherry picked from commit ad627b2) # Conflicts: # packaging/docker/Dockerfile
2 tasks
mergify bot
pushed a commit
that referenced
this pull request
May 19, 2025
the ubi docker image doesn't include cacerts, use the chainguard base image to retrieve them so we can use dependency management to keep them updated (cherry picked from commit ad627b2) # Conflicts: # packaging/docker/Dockerfile
2 tasks
mergify bot
pushed a commit
that referenced
this pull request
May 19, 2025
the ubi docker image doesn't include cacerts, use the chainguard base image to retrieve them so we can use dependency management to keep them updated (cherry picked from commit ad627b2)
2 tasks
mergify bot
added a commit
that referenced
this pull request
May 19, 2025
the ubi docker image doesn't include cacerts, use the chainguard base image to retrieve them so we can use dependency management to keep them updated (cherry picked from commit ad627b2) Co-authored-by: kruskall <[email protected]>
mergify bot
added a commit
that referenced
this pull request
May 19, 2025
* fix: add cacerts to ubi docker image (#16928) the ubi docker image doesn't include cacerts, use the chainguard base image to retrieve them so we can use dependency management to keep them updated (cherry picked from commit ad627b2) # Conflicts: # packaging/docker/Dockerfile * feat: fix conflicts --------- Co-authored-by: kruskall <[email protected]>
mergify bot
added a commit
that referenced
this pull request
May 19, 2025
* fix: add cacerts to ubi docker image (#16928) the ubi docker image doesn't include cacerts, use the chainguard base image to retrieve them so we can use dependency management to keep them updated (cherry picked from commit ad627b2) # Conflicts: # packaging/docker/Dockerfile * Update Dockerfile * Update Dockerfile * feat: fix conflicts --------- Co-authored-by: kruskall <[email protected]>
mergify bot
added a commit
that referenced
this pull request
May 19, 2025
* fix: add cacerts to ubi docker image (#16928) the ubi docker image doesn't include cacerts, use the chainguard base image to retrieve them so we can use dependency management to keep them updated (cherry picked from commit ad627b2) # Conflicts: # packaging/docker/Dockerfile * Update Dockerfile * Update cacert.pem * feat: fix conflicts --------- Co-authored-by: kruskall <[email protected]>
|
I'm afraid this is not working For the future, if the We can figure out how to enable the DRA validation by default, if needed in a follow up |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation/summary
the ubi docker image doesn't include cacerts, use the chainguard base image to retrieve them so we can use dependency management to keep them updated
note: 8.x is not affected because it's using the ubuntu image but it seems we're vendoring the cacerts there so there's value in backporting this
Checklist
For functional changes, consider:
How to test these changes
docker build --build-arg=GOLANG_VERSION=1.24.3 -t apm-server-test -f packaging/docker/Dockerfile .Related issues
Closes #16918