Skip to content

fix(#130): add SecurityContext to createInitContainerPatch #131

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 27, 2025

Conversation

toms-place
Copy link
Contributor

resolves: #130

This PR adds the default restricted SecurityContext to the initContainer patch, to allow the container to start in a namespace with the annotation pod-security.kubernetes.io/enforce: restricted.

@github-actions github-actions bot added the apm-k8s-attacher Mutating Webhook to attach apm agents on k8s label Dec 17, 2024
@toms-place toms-place changed the title feat(#130): add SecurityContext to createInitContainerPatch fix(#130): add SecurityContext to createInitContainerPatch Dec 17, 2024
kruskall
kruskall previously approved these changes Feb 26, 2025
@kruskall
Copy link
Member

LGTM! Thanks for the contribution and sorry for the late review! 🙇

@kruskall kruskall enabled auto-merge (squash) February 26, 2025 14:18
@kruskall kruskall disabled auto-merge February 26, 2025 14:18
@kruskall kruskall closed this Feb 26, 2025
@kruskall kruskall reopened this Feb 26, 2025
@toms-place
Copy link
Contributor Author

LGTM! Thanks for the contribution and sorry for the late review! 🙇

Thanks for checking it out! :)
Can I resolve the ci/NOTICE.txt check? Shall I bump the year or wait to rebase on the main branch?

@kruskall
Copy link
Member

feel free to update the year 🙂

@jackshirazi
Copy link
Contributor

run docs-build

@kruskall kruskall merged commit 4fddca2 into elastic:main Feb 27, 2025
8 checks passed
@toms-place toms-place deleted the feature/add-security-standards branch February 27, 2025 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
apm-k8s-attacher Mutating Webhook to attach apm agents on k8s
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pod violates PodSecurity "restricted:latest" - adhere to pod-security standards
3 participants