Skip to content

Check libc type is not reliable #1180

Open
@andrew-aladjev

Description

@andrew-aladjev

Hello, I have musl libc locally near glibc, because I am using some alpine project utils locally. This is fairly legal.

You are detecting musl in the following way:

public static Boolean CHECK_FOR_ALPINE() {
  return new File("/etc/alpine-release").exists();
}

I have /etc/alpine-release file locally, so your plugin tries to download a musl node version for me.

Downloading https://nodejs.org/dist/v18.12.0/node-v18.12.0-linux-x64-musl.tar.gz
[ERROR] Failed to execute goal com.github.eirslett:frontend-maven-plugin:install-node-and-npm (install-frontend-tools) on project: Could not download Node.js: Got error code 404 from the server.

But I am not using musl libc right now and I am not going to use musl libc for the target project. So please implement the following updates:

  1. Remove CHECK_FOR_ALPINE and everything related to the Alpine workaround.
  2. Add option for libc type: glibc, musl, uclibc, etc.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions