-
Notifications
You must be signed in to change notification settings - Fork 1
Feat/build multiple wheels #20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Hi Oisin, this looks nice, but it does not seem to work for other packages. I made a test release of findlibs, and it does not like the empty os matrix:
|
Just documenting after further investigation and discussion. Two current issues:
Will investigate further, but it seems like the easiest solution would be
|
Agreed to separate the wheels out from the cd for pure python packages. Plan is to have separate
|
I have now split the action for binary wheels out from the original cd-pypi action. Overview of changes are as follows
I've now got a way using these actions to build both purepython wheels as well as binary wheels in earthkit-hydro. |
@@ -0,0 +1,97 @@ | |||
--- | |||
name: cd-pypi |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe better to rename to cd-pypi-binwheel to avoid confusion
- uses: actions/checkout@v4 | ||
with: | ||
fetch-depth: "0" | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You might want to consider adding the tag/branch checks that cd-pypi has, for consistency. These checks actually saved us from an erroneous release a couple of weeks ago!
Adds the ability to also build wheels for packages. This is needed e.g. for Rust-Python packages.
This PR:
python -m build --sdist
instead of a genericpython -m build
. The checks on versions etc. are still done hereAn example successful workflow building wheels for a rust-python package is https://github.com/ecmwf/earthkit-hydro/actions/runs/14662296289/job/41149252856, which is largely driven via the
pyproject.toml
. I have a version on https://github.com/ecmwf/earthkit-hydro/tree/develop that's working