Update handling of updated configuration files #23
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merging in devel
Merge in develop
Merging in updated config change work
colonesej
reviewed
May 6, 2025
| @@ -8,83 +10,111 @@ import wellies as wl | |||
| ROOT_DIR = os.path.join(os.path.dirname(os.path.realpath(__file__))) | |||
|
|
|||
|
|
|||
| @dataclass | |||
There was a problem hiding this comment.
Hey @gareth-j , don't you think we can add these two classes to wellies/host.py? This would allow us to use the new api on existing suites just changing yml's and the Config implementation.
| submit_arguments: dict, | ||
| job_out: str, | ||
| workdir: str, | ||
| troika_kwargs: Optional[dict] = None, |
There was a problem hiding this comment.
I would maybe call this pyflow_host_kwargs ?? more verbose but a bit more general in my opinion
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates wellies to read the new config files.
Documentation will be updated separately with #19