Skip to content

Seperation of Dependencies #96

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
HCookie opened this issue Jan 27, 2025 · 1 comment
Open

Seperation of Dependencies #96

HCookie opened this issue Jan 27, 2025 · 1 comment
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers tech-debt training

Comments

@HCookie
Copy link
Member

HCookie commented Jan 27, 2025

What maintenance does this project need?

As we saw in #81, a bug/breaking change in one of our dependencies, can cripple the install of this package.

With #81, datashader is only needed in the plotting callbacks, this is not a critical component of training and ultimately should not be required dependency.

We should seperate these into optional dependencies and catch when a part of training is trying to use an uninstalled package.

# Optional Dependencies
[optional-dependencies]
plotting = ['datashader', 'matplotlib']
...

What other splits of dependencies make sense?

Organisation

ECMWF

@HCookie HCookie added enhancement New feature or request good first issue Good for newcomers training labels Jan 27, 2025
@HCookie HCookie self-assigned this Jan 27, 2025
@JPXKQX
Copy link
Member

JPXKQX commented Jan 29, 2025

I think you can add "pyshtools>=4.10.4" to the plotting.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers tech-debt training
Projects
Status: To be triaged
Development

When branches are created from issues, their pull requests are automatically linked.

3 participants