Skip to content

Change in newest version of datashader leads to bug in anemoi-training #81

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
sahahner opened this issue Jan 20, 2025 · 2 comments
Closed
Assignees
Labels
bug Something isn't working

Comments

@sahahner
Copy link
Member

What happened?

When installing newest version of dask (2025.1.0), the import of the datashader fails and one is not able to start a training.

What are the steps to reproduce the bug?

  • set up a new environment
  • install anemoi-training
  • start a training

Version

develop

Platform (OS and architecture)

leonardo/atos

Relevant log output

>>> import datashader as dsh
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/leonardo/home/userexternal/shahner0/2501_anemoi-core-waves/env-wave-core/lib/python3.11/site-packages/datashader/__init__.py", line 14, in <module>
    from . import data_libraries                             # noqa (API import)
    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/leonardo/home/userexternal/shahner0/2501_anemoi-core-waves/env-wave-core/lib/python3.11/site-packages/datashader/data_libraries/__init__.py", line 5, in <module>
    from . import dask    # noqa (API import)
    ^^^^^^^^^^^^^^^^^^
  File "/leonardo/home/userexternal/shahner0/2501_anemoi-core-waves/env-wave-core/lib/python3.11/site-packages/datashader/data_libraries/dask.py", line 55, in <module>
    bypixel.pipeline.register(dd.core.DataFrame)(dask_pipeline)
                              ^^^^^^^^^^^^^^^^^
AttributeError: module 'dask.dataframe.core' has no attribute 'DataFrame'

Accompanying data

No response

Organisation

ECMWF

@sahahner sahahner added the bug Something isn't working label Jan 20, 2025
@anaprietonem
Copy link
Collaborator

anaprietonem commented Jan 20, 2025

The issue is known by datashader community holoviz/datashader#1381 . They should do a release removing the deprecated dask dataframe functionality. Mean time we might need to pin Dask to or below (2024.12.1) to avoid this issue

Update: the datashader developers have now sorted the issue. The version in main already includes the fix, and a pypi release it's expected by end of the week. Once that's done, this issue could be closed

@HCookie
Copy link
Member

HCookie commented Jan 27, 2025

The pyproject.toml has been updated to pin dask<=2024.12.1.
Once datashader updates we will remove it and close this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Done
Development

No branches or pull requests

3 participants