Skip to content

Rename batchsize to batchsize_per_gpu #475

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 10, 2025
Merged

Conversation

sophie-xhonneux
Copy link
Contributor

@sophie-xhonneux sophie-xhonneux commented Jul 8, 2025

Description

Rename the batchsize config value to be more self explanatory. This will break configs from past checkpoints unfortunately.

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

Issue Number

Closes #497

Code Compatibility

  • I have performed a self-review of my code

Code Performance and Testing

  • I ran the uv run train and (if necessary) uv run evaluate on a least one GPU node and it works
  • If the new feature introduces modifications at the config level, I have made sure to have notified the other software developers through Mattermost and updated the paths in the $WEATHER_GENERATOR_PRIVATE directory

Dependencies

  • I have ensured that the code is still pip-installable after the changes and runs
  • I have tested that new dependencies themselves are pip-installable.
  • I have not introduced new dependencies in the inference portion of the pipeline

Documentation

  • My code follows the style guidelines of this project
  • I have updated the documentation and docstrings to reflect the changes
  • I have added comments to my code, particularly in hard-to-understand areas

Additional Notes

@sophie-xhonneux sophie-xhonneux requested a review from tjhunter July 8, 2025 15:15
@clessig
Copy link
Collaborator

clessig commented Jul 8, 2025

Can you please ruff it. Then it's ready to be merged.

Copy link
Collaborator

@clessig clessig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did a quick test and looks all good.

@clessig clessig removed the request for review from tjhunter July 10, 2025 17:27
@clessig clessig merged commit 15c8c92 into develop Jul 10, 2025
5 of 6 checks passed
@clessig clessig deleted the sophiex/dev/rename-batchsize branch July 10, 2025 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change batch_size to batchsize_per_gpu
2 participants