Remove print statements for logging (#421)

pyproject.toml

@@ -85,7 +85,9 @@ select = [
     # isort
     "I",
     # Banned imports
-    "TID"
+    "TID",
+    # print
+    "T201"
 ]
 
 # These rules are sensible and should be enabled at a later stage.

scripts/check_gh_issue.py

@@ -13,9 +13,11 @@
 https://stackoverflow.com/questions/60717142/getting-linked-issues-and-projects-associated-with-a-pull-request-form-github-ap
 """
 
+import logging
+import re
+
 import requests
 from bs4 import BeautifulSoup
-import re
 
 repo = "ecmwf/WeatherGenerator"
 
@@ -31,6 +33,7 @@
 See https://docs.github.com/en/issues/tracking-your-work-with-issues/using-issues/linking-a-pull-request-to-an-issue
 """
 
+_logger = logging.getLogger(__name__)
 
 if __name__ == "__main__":
     import argparse
@@ -47,13 +50,13 @@
     msg = msg_template.format(pr=pr, repo=repo)
 
     if not issueForm:
-        print(msg)
+        _logger.warning(msg)
         exit(1)
     issues = [i["href"] for i in issueForm[0].find_all("a")]
     issues = [i for i in issues if i is not None and repo in i]
-    print(f"Linked issues for PR {pr}:")
-    print(f"Found {len(issues)} linked issues.")
-    print("\n".join(issues))
+    _logger.info(f"Linked issues for PR {pr}:")
+    _logger.warning(f"Found {len(issues)} linked issues.")
+    _logger.info("\n".join(issues))
     if not issues:
-        print(msg)
+        _logger.warning(msg)
         exit(1)

src/weathergen/model/model.py

@@ -1,3 +1,4 @@
+# ruff: noqa: T201
 # (C) Copyright 2025 WeatherGenerator contributors.
 
 #

src/weathergen/train/trainer.py

@@ -682,14 +682,13 @@ def validate(self, epoch):
                     self.train_logger.add_val(samples, losses_all, stddev_all)
 
                 if self.cf.rank == 0:
-                    print(
-                        f"validation ({cf.run_id}) : {epoch:03d} :",
-                        f" loss = {torch.nanmean(losses_all[0]):.4E}",
-                        flush=True,
-                    )
+                    _logger.info(f"validation ({cf.run_id}) : {epoch:03d}")
+                    _logger.info(f": loss = {torch.nanmean(losses_all[0]):.4E}")
+                    # creating a string with all stream losses
+                    stream_string = ""
                     for i_obs, rt in enumerate(cf.streams):
-                        print("{}".format(rt["name"]) + f" : {losses_all[0, i_obs]:0.4E}")
-
+                        stream_string += f" {rt['name']} : {losses_all[0, i_obs]:0.4E} \t"
+                    _logger.info(stream_string)
         # avoid that there is a systematic bias in the validation subset
         self.dataset_val.advance()
 
@@ -784,7 +783,7 @@ def log_terminal(self, bidx, epoch):
                 pstr = "{:03d} : {:05d}/{:05d} : {:06d} : loss = {:.4E} "
                 pstr += "(lr={:.2E}, s/sec={:.3f})"
                 len_dataset = len(self.data_loader) // self.cf.batch_size
-                print(
+                _logger.info(
                     pstr.format(
                         epoch,
                         bidx,
@@ -793,15 +792,11 @@ def log_terminal(self, bidx, epoch):
                         np.nanmean(l_avg[0]),
                         self.lr_scheduler.get_lr(),
                         (self.print_freq * self.cf.batch_size) / dt,
-                    ),
-                    flush=True,
+                    )
                 )
-                print("\t", end="")
+                stream_string = ""
                 for i_obs, rt in enumerate(self.cf.streams):
-                    print(
-                        "{}".format(rt["name"]) + f" : {l_avg[0, i_obs]:0.4E} \t",
-                        end="",
-                    )
-                print("\n", flush=True)
-
+                    # creating a string with all stream losses
+                    stream_string += f"{rt['name']} : {l_avg[0, i_obs]:0.4E} \t"
+                _logger.info("\t" + stream_string)
             self.t_start = time.time()

src/weathergen/utils/compare_run_configs.py

@@ -8,10 +8,14 @@
 # nor does it submit to any jurisdiction.
 
 import argparse
+import logging
 
 import dictdiffer
 from obslearn.utils.config import Config
 
+_logger = logging.getLogger(__name__)
+
+
 if __name__ == "__main__":
     parser = argparse.ArgumentParser()
     parser.add_argument("-r1", "--run_id_1", required=True)
@@ -31,4 +35,4 @@
         #   name = cf1.streams[item[1][1]]['name']
         #   item[1][1] = name
 
-        print(f"{item[1]} :: {item[2]}")
+        _logger.info(f"Difference {item[1]} :: {item[2]}")

src/weathergen/utils/run_id.py

@@ -6,8 +6,11 @@
 # In applying this licence, ECMWF does not waive the privileges and immunities
 # granted to it by virtue of its status as an intergovernmental organisation
 # nor does it submit to any jurisdiction.
+import logging
 
 from weathergen.train.utils import get_run_id
 
+_logger = logging.getLogger(__name__)
+
 if __name__ == "__main__":
-    print(get_run_id())
+    _logger.info(f"Run ID: {get_run_id()}")

tests/test_config.py

@@ -96,7 +96,6 @@ def write_stream_file(write_path, content: str):
 
 
 def get_expected_config(key, config):
-    print(key, config)
     config = OmegaConf.create(config)
     config.name = key
     return config