Defining new action for python wrapper wheels #161
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
tmi
force-pushed
the
action/pythonWrapperWheel
branch
from
30943fa to
6081ff5
Compare
tmi
force-pushed
the
action/pythonWrapperWheel
branch
from
6081ff5 to
31e17cc
Compare
iainrussell
reviewed
Feb 6, 2025
| # we'd ideally not reexecute the compile step multiple times, but it | ||
| # (non-essentially) depends on a matrix-based step. Add more pythons, possibly | ||
| # more manylinuxes | ||
| python_version: ["3.11", "3.13"] |
There was a problem hiding this comment.
I'd add more Pythons from the start (3.9 to 3.13) because it will be a pain to add them later if we've already uploaded wheels for some Python versions and not others (I know from experience!)
There was a problem hiding this comment.
sure, I just didn't want the initial test to run that long :), I'll update pre-merge. Also, note each entry in the matrix still requires the full compilation (redundantly...)
iainrussell
approved these changes
Feb 7, 2025
There was a problem hiding this comment.
@tmi - I'm happy with this - are you ready for me to merge it in?
|
@iainrussell yes, happy with this being merged |
|
Merged, and it now has the v2 tag 🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The common logic behind the python wrapper wheel publishing
Demonstration of "success": https://github.com/ecmwf/eckit/actions/runs/13182965534/job/36798126868 -- it actually failed because the wheels already exist (or because of the compile error thats to be fixed elsewhere). But it executed what it should have execute, so all good from the local pov
I have a single parameter because the validation wasn't passing otherwise -- but so far we don't need any parametrization