Skip to content

Add quickfix for methods reducing visibility #442

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
fbricon opened this issue Nov 17, 2017 · 2 comments
Closed

Add quickfix for methods reducing visibility #442

fbricon opened this issue Nov 17, 2017 · 2 comments
Labels
code-actions enhancement
Milestone
End September 2019

Comments

@fbricon
Copy link
Contributor

fbricon commented Nov 17, 2017

Handle the following cases in QuickFixProcessor:

case IProblem.InheritedMethodReducesVisibility:
case IProblem.MethodReducesVisibility:
case IProblem.OverridingNonVisibleMethod:
    ModifierCorrectionSubProcessor.addChangeOverriddenModifierProposal(context,problem, proposals, 
    ModifierCorrectionSubProcessor.TO_VISIBLE);
@fbricon
Copy link
Contributor Author

fbricon commented Sep 16, 2019

@NikolasKomonen please see if it can be implemented with the current state of jdt.core

@NikolasKomonen NikolasKomonen mentioned this issue Sep 20, 2019
Merged
@fbricon fbricon added this to the End September 2019 milestone Sep 24, 2019
@fbricon fbricon closed this as completed Sep 24, 2019
@fbricon
Copy link
Contributor Author

fbricon commented Sep 24, 2019

Thanks @NikolasKomonen!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
code-actions enhancement
Projects
None yet
Milestone
End September 2019
Development

No branches or pull requests
1 participant
@fbricon