Quick fix implementation for method invisibility #1187
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes issue eclipse-jdtls#440 Signed-off-by: Nikolas Komonen <[email protected]>
|
Related issue - #1183 |
|
Wow this is super weird: the fix is not proposed when you implement the method of an interface or overriding the method of a class from the JDK (or all binaries?). This can be reproduced in Eclipse itself. @rgrunber is this a regression upstream or a known bug? |
|
I think this is a bug. The problem happens at https://github.com/eclipse/eclipse.jdt.ui/blob/c25e5a83e3a015ddf6bfbef854ccc96a816cf267/org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/text/correction/ModifierCorrectionSubProcessor.java#L277 . It only checks for super classes, but not interfaces, so the inheritted method is never located. I have filed https://bugs.eclipse.org/bugs/show_bug.cgi?id=551383 . |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue #442
Signed-off-by: Nikolas Komonen [email protected]