Skip to content

Allow applications to load plugins #953

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from
Apr 22, 2024
Merged

Allow applications to load plugins #953

merged 13 commits into from
Apr 22, 2024

Conversation

Mallets
Copy link
Member

@Mallets Mallets commented Apr 19, 2024

Plugins loading is moved from zenohd into Runtime::init.
This allows any application, written in any language, to load Rust plugins by passing the right configuration.

This approach does not require the addition of any API in the bindings since everything is handled via the configuration.

Sister PRs:

@Mallets Mallets requested review from milyin and gabrik April 19, 2024 15:55
@Mallets Mallets merged commit cbeffcf into main Apr 22, 2024
14 of 19 checks passed
@Mallets Mallets deleted the plugin_loading branch April 22, 2024 11:07
@@ -364,6 +364,8 @@
/// Configure the Admin Space
/// Unstable: this configuration part works as advertised, but may change in a future release
adminspace: {
// Enables the admin space
enabled: false,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we make this a mode dependent value?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's always disabled by default. zenohd activates it but if an application starts in router mode admin space is not activated by default if not explicitly requested.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants