fix: pin home to 0.5.9 #1673
Merged
fix: pin home to 0.5.9 #1673
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0.5.11 requires rustc 1.81 so we pin the dependency to the latest one working with the 1.70 series.
|
PR missing one of the required labels: {'enhancement', 'new feature', 'internal', 'breaking-change', 'bug', 'dependencies', 'documentation'} |
diogomatsubara
added
the
dependencies
yellowhatter
approved these changes
Dec 17, 2024
simpleton
added a commit
to simpleton/zenoh
that referenced
this pull request
May 23, 2025
The rust toolchain version has be upgraded to 1.8.5 in eclipse-zenoh#1803 we don't need to pin the home to 0.5.9 (eclipse-zenoh#1673)
facebook-github-bot
pushed a commit
to facebookexperimental/rust-shed
that referenced
this pull request
May 23, 2025
Summary: Since [zenoh#1673](eclipse-zenoh/zenoh#1673), upstream misguidedly restricts the range of versions of `home` that `zenoh-util` is usable with in their Cargo.toml, instead of with a lockfile. `home` is an extremely widely used dependency so this problem in zenoh has been blocking other crates from being updated. For example recent versions of `cargo` requires `home` ^0.5.11. This diff forks several zenoh crates at 1.4.0 to undo the misguided `home` dependency. This is not a permanent fork because eventually zenoh will change its MSRV, hopefully. Reviewed By: diliop Differential Revision: D75295567 fbshipit-source-id: ca969009da2f2faabedc29bca494a4aa88328a91
facebook-github-bot
pushed a commit
to facebook/sapling
that referenced
this pull request
May 23, 2025
Summary: Since [zenoh#1673](eclipse-zenoh/zenoh#1673), upstream misguidedly restricts the range of versions of `home` that `zenoh-util` is usable with in their Cargo.toml, instead of with a lockfile. `home` is an extremely widely used dependency so this problem in zenoh has been blocking other crates from being updated. For example recent versions of `cargo` requires `home` ^0.5.11. This diff forks several zenoh crates at 1.4.0 to undo the misguided `home` dependency. This is not a permanent fork because eventually zenoh will change its MSRV, hopefully. Reviewed By: diliop Differential Revision: D75295567 fbshipit-source-id: ca969009da2f2faabedc29bca494a4aa88328a91
milyin
pushed a commit
that referenced
this pull request
May 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
0.5.11 requires rustc 1.81 so we pin the dependency to the latest one working with the 1.70 series.
Fixes https://github.com/eclipse-zenoh/zenoh/actions/runs/12369352118/job/34522022150