add empty gravestone values for Sample, Reply, ReplyError, Query and Hello #1571
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
PR missing one of the required labels: {'breaking-change', 'new feature', 'dependencies', 'documentation', 'bug', 'enhancement', 'internal'} |
DenisBiryukov91
changed the title
|
@DenisBiryukov91 is this PR still valid or should we close it? |
|
@Mallets. Yes it is still valid, although the related task to provide functionality to move out of loaned types in zenoh-c and make std::move in c++ work more closely to how users would expect, has quite low priority. |
milyin
approved these changes
Feb 15, 2025
There was a problem hiding this comment.
The approach for Query can be changed (better to have real empty state, but this will require too much rework of other code), but this variant is ok.
The goal of this update is to provide "dummy" states for zenoh-c "take from loaned mut" operation - see PR eclipse-zenoh/zenoh-c#718
milyin
added a commit
that referenced
this pull request
Feb 15, 2025
milyin
added a commit
that referenced
this pull request
Feb 15, 2025
* followup to #1571: reliablity, sourceinfo to unstable * typo fix to pass CI
milyin
added a commit
that referenced
this pull request
Feb 15, 2025
* followup to #1571: reliablity, sourceinfo to unstable * typo fix to pass CI * compilation fix
mmusselman-crl
pushed a commit
to jmonticelli/zenoh
that referenced
this pull request
Apr 30, 2025
…Hello (eclipse-zenoh#1571) * add empty gravestone values for Sample, Reply, Query and Hello * add empty gravestone value for ReplyErr
mmusselman-crl
pushed a commit
to jmonticelli/zenoh
that referenced
this pull request
Apr 30, 2025
…enoh#1775) * followup to eclipse-zenoh#1571: reliablity, sourceinfo to unstable * typo fix to pass CI
mmusselman-crl
pushed a commit
to jmonticelli/zenoh
that referenced
this pull request
Apr 30, 2025
* followup to eclipse-zenoh#1571: reliablity, sourceinfo to unstable * typo fix to pass CI * compilation fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add empty gravestone values for Sample, Reply, ReplyError, Query and Hello - required to support move operations in C++