Skip to content

Admin space: change prefix from '@/service/<uuid>/mqtt' to '@mqtt/<uuid>' #89

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 29, 2024

Conversation

JEnoch
Copy link
Member

@JEnoch JEnoch commented Apr 29, 2024

The plugin had its admin space under @/service/<uuid>/mqtt/**.
The main drawback is that it's mixed with Zenoh's admin space which is prefixed with @/.

For separation of concerns and for coherency with the plugin for ROS2 which uses @ros2/<uuid> as prefix, this PR changes the admin prefix for MQTT plugin to @mqtt/<uuid>

Migration guide:

  • @/service/<uuid>/mqtt/version becomes:
    @mqtt/<uuid>/version
  • @/service/<uuid>/mqtt/config becomes:
    @mqtt/<uuid>/config

@JEnoch JEnoch added the enhancement New feature or request label Apr 29, 2024
@JEnoch JEnoch requested a review from gabrik April 29, 2024 14:21
@JEnoch JEnoch self-assigned this Apr 29, 2024
@JEnoch JEnoch enabled auto-merge (squash) April 29, 2024 14:23
@JEnoch JEnoch merged commit 7098602 into main Apr 29, 2024
6 checks passed
@JEnoch JEnoch deleted the adminspace_change2 branch April 29, 2024 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants