Skip to content

Removing setPriority and setCongestionControl from publisher + adding express config to publisher builder #110

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

DariusIMP
Copy link
Member

  • Removing functions that allowed users to dynamically set the QoS parameters after Zenoh PR #1124, those being Publisher.setCongestionControl(cc) and Publisher.setPriority(priority).
  • Allowing users to specify the express QoS config parameter while building the publisher.
  • Some refactoring on the zenoh-jni code regarding the publisher.

@DariusIMP DariusIMP force-pushed the issue/publisher_api branch from e506029 to 8142692 Compare June 12, 2024 13:50
@OlivierHecart OlivierHecart merged commit 45881e6 into eclipse-zenoh:dev/1.0.0 Jun 12, 2024
6 checks passed
@DariusIMP DariusIMP deleted the issue/publisher_api branch June 12, 2024 14:35
DariusIMP added a commit to ZettaScaleLabs/zenoh-kotlin that referenced this pull request Aug 5, 2024
… express config to publisher builder (eclipse-zenoh#110)

* issue(Publisher QoS): adding express config for the Publisher.

* issue(Publisher QoS): removing publisher setPriority and setCongestionControl during runtime.

Done after changes on Zenoh from eclipse-zenoh/zenoh#1124

* issue(Publisher QoS): refactoring publisher.rs on zenoh-jni
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants