Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: ensure that the dirty state is correctly set even when the current save operation is canceled (#15308). #15310

Merged
merged 1 commit into from
Mar 31, 2025

Conversation

lessmost
Copy link
Contributor

What it does

fix issue #15308

How to test

  1. Open an text file
  2. Make some edits, and intermediately press cmd/ctrl+s twice quickly
  3. Note that the editor's dirty state icon will correctly disappear.

Follow-ups

Breaking changes

  • This PR introduces breaking changes and requires careful review. If yes, the breaking changes section in the changelog has been updated.

Attribution

Review checklist

Reminder for reviewers

@JonasHelming JonasHelming requested a review from msujew March 31, 2025 18:05
Copy link
Member

@msujew msujew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the contribution @lessmost, looks good to me 👍

@msujew msujew added bug bugs found in the application monaco issues related to monaco labels Mar 31, 2025
@msujew msujew merged commit c4a0cfa into eclipse-theia:master Mar 31, 2025
9 of 11 checks passed
@github-actions github-actions bot added this to the 1.60.0 milestone Mar 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug bugs found in the application monaco issues related to monaco
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants