Align AI chat toggle keybinding with VS Code on macOS

[cdamus]

What it does

On macOS, assign Control+Command+I keybinding and on other platforms Control+Alternate+I to align with VS Code on Mac and not clash with Chrome devtools on all platforms.

Fixes #14814

How to test

1. On macOS,
   1. Hit ⌃+⌘+I repeatedly and see the AI Chat view toggle on and off.
   2. Hit ⌥+⌘+I and see the Chrome devtools appear.
2. On Linux and Windows,
   1. Hit Ctrl+Alt+I repeatedly and see the AI Chat view toggle on and off.
   2. Hit whatever is the platform's keyboard shortcut for Chrome devtools and see them appear.

Review the keybinding editor. On macOS, you should see something like this (never mind that Theia shows the modifiers in the wrong order):

Follow-ups

None.

Breaking changes

None.

Attribution

None.

Review checklist

• As an author, I have thoroughly tested my changes and carefully followed the review guidelines

Reminder for reviewers

• As a reviewer, I agree to behave in accordance with the review guidelines

[JonasHelming]

Thanks, LGTM (on Linux)

@kittaakos Could you confirm this solves your issue?

[kittaakos]

Thank you for the changes. I confirm that I can use the default shortcut Option + Command + I to open the DevTools in the browser.

The recent devex improvements on macOS are much appreciated, but the PR only partially addresses #14814. I find the title of the PR to be misleading if we merge the changeset as is. The default shortcut for opening the AI chat (GitHub Copilot) in VS Code is Shift + Command + I on macOS.

From #14814 (comment):

This would allow users to utilize the ⌘+⇧+I combination for the AI chat.

Therefore, binding the Theia AI chat to Ctrl + Command + I does not align with VS Code's shortcut.

Please note that the current Shift + Command + I shortcut is already assigned to the Outline view on macOS and Windows. (I'm unsure why it isn't bound on Linux, though):

theia/packages/outline-view/src/browser/outline-view-contribution.ts

Lines 63 to 66 in b247eb3

	toggleCommandId: 'outlineView:toggle',
	toggleKeybinding: OS.type() !== OS.Type.Linux
	? 'ctrlcmd+shift+i'
	: undefined

I'm not aware of the direction for the Theia AI chat, is it intended to be a complete replacement for Copilot? If so, I would suggest that Theia aims to make the user experience as similar to VS Code as possible.

[JonasHelming]

@kittaakos When you refer to "Copilot" Are you referring to the action "workbench.action.chat.open" ?

I believe Christian checked the default keybinding for this on Mac and it was ⌃+⌘+I (not SHIFT),

AFAIK, the chat view is not contributed by Copilot (says contributed by "System"), hence we want to align the keybindings of both chat views.

[kittaakos]

I believe Christian checked the default keybinding for this on Mac and it was ⌃+⌘+I (not SHIFT),

Yes, I was wrong. Thanks for the correction. I am consistently using the openEditSession instead of open...

(👆 This is what I never use, apparently; it does not have the current editor as the initial context.)

All is looking good in the PR.