Skip to content

chore(licenseinfo): Reporting Component Subsection #438

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 26, 2019
Merged

chore(licenseinfo): Reporting Component Subsection #438

merged 1 commit into from
Feb 26, 2019

Conversation

dreh23
Copy link

@dreh23 dreh23 commented Jan 14, 2019

Added Reporting features:

  • Component Subsection

Signed-off-by: Johannes Amorosa [email protected]

@maxhbr
Copy link
Contributor

maxhbr commented Jan 16, 2019

please use the semantic commit convention to format commit messages, e.g. see: https://github.com/eclipse/sw360/wiki/Dev-Semantic-Commits

maxhbr
maxhbr requested changes Jan 16, 2019
View reviewed changes
Copy link
Contributor

@maxhbr maxhbr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added some comments.

This PR also adds templateReport.docx and I can not find any occurrence of the file name in the source code. Is it used?

libraries/lib-datahandler/src/main/thrift/licenseinfo.thrift
@@ -70,6 +70,7 @@ struct LicenseInfoParsingResult {
31: optional string name,
32: optional string version,
33: optional string componentType,
34: optional Release release,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't this potentially redundant information? E.g. if 30 to 33 is set

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How do you want us to handle this?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

only add only the necessary information / refactor the other part

@mcjaeger mcjaeger added needs general test This is general testing, meaning that there is no org specific issue to check for WIP work in progress labels Jan 16, 2019
@dreh23 dreh23 force-pushed the johannesamorosa/ReportingComponentSubsection branch from 51c32e6 to 1582a67 Compare January 18, 2019 09:01
@dreh23
Copy link
Author

dreh23 commented Jan 21, 2019 •
edited
Loading

added some comments.

This PR also adds templateReport.docx and I can not find any occurrence of the file name in the source code. Is it used?

Yes it is used. An older version of this document is already in master. This PR adds additional tables in the document.

@mcjaeger mcjaeger self-assigned this Jan 21, 2019
@dreh23 dreh23 force-pushed the johannesamorosa/ReportingComponentSubsection branch from 1582a67 to 0eaf77b Compare January 21, 2019 15:37
@dreh23 dreh23 force-pushed the johannesamorosa/ReportingComponentSubsection branch 3 times, most recently from 3f5c822 to 65df434 Compare January 25, 2019 10:32
feat(project): Reporting Improvements
ed7e9f9 
This pull request adds:

- Reporting: Components Subsection#375

Signed-off-by: Johannes Amorosa <[email protected]>
@dreh23 dreh23 force-pushed the johannesamorosa/ReportingComponentSubsection branch from 65df434 to ed7e9f9 Compare February 21, 2019 20:52
@mcjaeger
Copy link
Contributor

@dreh23 please rebase (otherwise I would need to install thrift 093)

@mcjaeger mcjaeger removed the WIP work in progress label Feb 25, 2019
@dreh23 dreh23 mentioned this pull request Feb 25, 2019
Open
@mcjaeger mcjaeger self-requested a review February 25, 2019 20:46
mcjaeger
mcjaeger approved these changes Feb 25, 2019
View reviewed changes
Copy link
Contributor

@mcjaeger mcjaeger left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

simple cases seem to work

@dreh23
Copy link
Author

dreh23 commented Feb 26, 2019

You removed WIP. Do I need to address the data structure refactoring or do we have a go to merge?

@mcjaeger mcjaeger merged commit 3bbd56e into eclipse-sw360:master Feb 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maxhbr maxhbr maxhbr approved these changes

@mcjaeger mcjaeger mcjaeger approved these changes

Assignees

@mcjaeger mcjaeger

@maierthomas maierthomas

Labels
needs general test This is general testing, meaning that there is no org specific issue to check for
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dreh23 @maxhbr @mcjaeger @maierthomas