Allow user select default editor per content type #1665
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test Results 918 files + 1 918 suites +1 50m 43s ⏱️ + 11m 7s For more details on these failures, see this check. Results for commit b3137d1. ± Comparison against base commit f61769f. ♻️ This comment has been updated with latest results. |
Extended "Content Types" preference page with possibility to set one of the editors configured for a content type to "default" editor. The preference will be saved into org.eclipse.ui.workbench preference store. The key is a combination of a prefix with content type id, the value is the editor id, for example to associate base XML content type with generic editor, following is saved: `defaultEditorForContentType_org.eclipse.core.runtime.xml=org.eclipse.ui.genericeditor.GenericEditor` By default nothing is changed for IDE, but products can set defaults using the product customization, e.g. for the example above it would be: `org.eclipse.ui.workbench/defaultEditorForContentType_org.eclipse.core.runtime.xml=org.eclipse.ui.genericeditor.GenericEditor` Fixes eclipse-platform#1659
iloveeclipse
force-pushed
the
issue_1659
branch
from
42f5c6d to
b3137d1
Compare
|
@mickaelistria , @travkin79: if there are no objections, I would like to merge that now. |
|
No objections from my side. Thank you very much, @iloveeclipse! |
|
I have not looked at the implementation detail, but I think the feature and the implementation make a lot of sense to be added. So no objection from my side, all the contrary! |
This was referenced May 31, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extended "Content Types" preference page with possibility to set one of the editors configured for a content type to "default" editor.
The preference will be saved into
org.eclipse.ui.workbenchpreference store.The key is a combination of a prefix with content type id, the value is the editor id, for example to associate base XML content type with generic editor, following is saved:
defaultEditorForContentType_org.eclipse.core.runtime.xml=org.eclipse.ui.genericeditor.GenericEditorBy default nothing is changed for IDE, but products can set defaults using the product customization, e.g. for the example above it would be:
org.eclipse.ui.workbench/defaultEditorForContentType_org.eclipse.core.runtime.xml=org.eclipse.ui.genericeditor.GenericEditorFixes #1659