Skip to content

jdk21 java/util/concurrent/StructuredTaskScope/StructuredThreadDumpTest cannot find symbol HotSpotDiagnosticMXBean #17634

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
pshipton opened this issue Jun 21, 2023 · 4 comments

Comments

@pshipton
Copy link
Member

https://openj9-jenkins.osuosl.org/job/Grinder_testList_2/46/ - amac jdk21
java/util/concurrent/StructuredTaskScope/StructuredThreadDumpTest.java

15:11:14  /Users/jenkins/workspace/Grinder_testList_2/aqa-tests/openjdk/openjdk-jdk/test/jdk/java/util/concurrent/StructuredTaskScope/StructuredThreadDumpTest.java:43: error: cannot find symbol
15:11:14  import com.sun.management.HotSpotDiagnosticMXBean.ThreadDumpFormat;
15:11:14                                                   ^
15:11:14    symbol:   class ThreadDumpFormat
15:11:14    location: interface HotSpotDiagnosticMXBean
15:11:14  /Users/jenkins/workspace/Grinder_testList_2/aqa-tests/openjdk/openjdk-jdk/test/jdk/java/util/concurrent/StructuredTaskScope/StructuredThreadDumpTest.java:149: error: cannot find symbol
15:11:14                  .dumpThreads(file.toString(), ThreadDumpFormat.JSON);
15:11:14                                                ^
15:11:14    symbol:   variable ThreadDumpFormat
15:11:14    location: class StructuredThreadDumpTest
@pshipton
Copy link
Member Author

@babsingh pls take a look. Should OpenJ9 provide an equivalent JSON formatted Thread dump implementation, or start including a subset of HotSpotDiagnosticMXBean?

I didn't see it at first, but this is a dup of #15278 which excluded the test. The test was renamed since it's no longer an incubator.

@tajila fyi

@babsingh
Copy link
Contributor

@babsingh pls take a look. Should OpenJ9 provide an equivalent JSON formatted Thread dump implementation, or start including a subset of HotSpotDiagnosticMXBean?

After a quick look, I believe that we might be able to to consume HotSpotDiagnosticMXBean as-is. Let me do some experimentation to see if this is feasible.

babsingh added a commit to babsingh/openj9 that referenced this issue Jun 30, 2023
This will allow us to enable a JTReg test for Structured Concurrency.

JTReg test: StructuredTaskScope/StructuredThreadDumpTest

Related: eclipse-openj9#17634

Signed-off-by: Babneet Singh <[email protected]>
babsingh added a commit to babsingh/aqa-tests that referenced this issue Jul 6, 2023
eclipse-openj9/openj9#17709 adds the required support to enable
StructuredThreadDumpTest.

Related issues which can be closed after the test is enabled:
- eclipse-openj9/openj9#17634
- eclipse-openj9/openj9#15278

Signed-off-by: Babneet Singh <[email protected]>
llxia pushed a commit to adoptium/aqa-tests that referenced this issue Jul 6, 2023
eclipse-openj9/openj9#17709 adds the required support to enable
StructuredThreadDumpTest.

Related issues which can be closed after the test is enabled:
- eclipse-openj9/openj9#17634
- eclipse-openj9/openj9#15278

Signed-off-by: Babneet Singh <[email protected]>
@babsingh babsingh closed this as completed Jul 6, 2023
@pshipton
Copy link
Member Author

@babsingh a reminder to remove the test excluded label when a test is re-enabled.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants