Skip to content

Update to LSP4J 0.14.0 #136

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 29, 2022
Merged

Conversation

cdietrich
Copy link
Contributor

Update to LSP4J 0.14.0
Fixes #135

@cdietrich
Copy link
Contributor Author

release is not out yet

@jonahgraham
Copy link
Contributor

Error extracted from the PR build

[INFO] org.eclipse.lsp4e 0.13.11-SNAPSHOT ................. FAILURE [ 21.237 s]

-- snip --

[ERROR] Failed to execute goal org.eclipse.tycho.extras:tycho-p2-extras-plugin:2.7.0:compare-version-with-baselines (compare-version-with-baseline) on project org.eclipse.lsp4e: Only qualifier changed for (org.eclipse.lsp4e/0.13.11.202205261506). Expected to have bigger x.y.z than what is available in baseline (0.13.11.202205241336) -> [Help 1]

@cdietrich
Copy link
Contributor Author

cdietrich commented May 26, 2022

i have no clue how baselines are managed. what needs to be changed?
readme says 1 change per release. was lsp4e already released for 2022-06?

Fixes eclipse-lsp4e#135

Signed-off-by: Christian Dietrich <[email protected]>
@jonahgraham
Copy link
Contributor

i have no clue how baselines are managed. what needs to be changed? readme says 1 change per release. was lsp4e already released for 2022-06?

Yes, already released multiple times, including yesterday: https://github.com/eclipse/lsp4e/releases/tag/0.20.4

Your latest patchset builds ok, but tests fail. I assume that they are simply flaky tests, but someone else needs to review.

@jonahgraham jonahgraham requested a review from mickaelistria May 26, 2022 16:18
@mickaelistria mickaelistria merged commit 4e8955c into eclipse-lsp4e:master May 29, 2022
@mickaelistria
Copy link
Contributor

All tests passed in a rebuild; let's merge.
Thanks!

@cdietrich cdietrich deleted the cd_lsp4j0140 branch May 30, 2022 03:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update to lsp4j 0.14.0
3 participants