Skip to content

Convert from type to 'var';Convert from 'var' to the appropriate type #722

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 17, 2018

Conversation

snjeza
Copy link
Contributor

@snjeza snjeza commented Jul 15, 2018

Fixes #696 and #697

The #696 and #697 issues use the same code. That is the reason I have fixed them in the same PR.

Signed-off-by: Snjezana Peco [email protected]

@snjeza snjeza requested review from gorkem and fbricon July 15, 2018 18:34
@fbricon
Copy link
Contributor

fbricon commented Jul 16, 2018

I opened https://bugs.eclipse.org/bugs/show_bug.cgi?id=537083 so that we keep track of the need to migrate org.eclipse.jdt.internal.corext.fix.TypeParametersFix (and dependencies) to jdt.core. cc @rgrunber @jjohnstn

@@ -231,5 +289,52 @@ private int rank(ITypeBinding type) {
});
}

private void handledInferredParametrizedType(ASTNode node, ASTNode declaringNode, AST ast, ASTRewrite rewrite, ImportRewrite importRewrite, ImportRewriteContext context) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

handledInferredParameterizedType

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fbricon Fixed.

@fbricon
Copy link
Contributor

fbricon commented Jul 17, 2018

test this please

@fbricon
Copy link
Contributor

fbricon commented Jul 17, 2018

@snjeza can you please rebase / fix compilation errors against master? @jjohnstn 's last commit mostly broke TypeParametersFix

@snjeza
Copy link
Contributor Author

snjeza commented Jul 17, 2018

@fbricon I have done it.

@@ -0,0 +1,73 @@
/*******************************************************************************
* Copyright (c) 2016-2017 Red Hat Inc. and others.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2018

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fbricon I have fixed it.

@fbricon fbricon merged commit e8e3c5e into eclipse-jdtls:master Jul 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Convert from var to the appropriate type
2 participants