Skip to content

Type definition snippets should respect java.templates.typeComment. #3301

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 23, 2024
Merged

Type definition snippets should respect java.templates.typeComment. #3301

merged 1 commit into from
Oct 23, 2024

Conversation

rgrunber
Copy link
Contributor

@rgrunber
Copy link
Contributor Author

rgrunber commented Oct 18, 2024 •
edited
Loading

  • A testcase in CompletionHandlerTest would be nice (updated existing testcase instead that covers this)
  • Address my comment on the issue of

    • We should also make sure that things that create new files through server-side resource operations populate the new file correctly.

@rgrunber rgrunber merged commit e738410 into eclipse-jdtls:master Oct 23, 2024
6 of 7 checks passed
@rgrunber rgrunber deleted the fix-3295 branch October 23, 2024 03:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use java.templates.typeComment on code snippet for "class"
1 participant
@rgrunber