Skip to content

Fix first letter matching for method overrides #2902

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 11, 2023

Conversation

hopehadfield
Copy link
Contributor

Copy link
Contributor

@rgrunber rgrunber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Just a few unrelated things I noticed, you may want to address in a separate PR :

--- old.txt	2023-10-11 18:16:55.284431675 -0400
+++ new.txt	2023-10-11 18:18:12.486804631 -0400
@@ -5,21 +5,21 @@
                 "description": "boolean"
             },
             "kind": 2,
-            "detail": "Override method in 'Visitor'",
-            "sortText": "999999099",
-            "filterText": "visit",
+            "detail": "Visitor.visit(ElemA input, String something) : boolean",
+            "sortText": "999998971",
+            "filterText": "visit(ElemA input, String something) : boolean",
             "insertText": "visit",
             "textEditText": "visit",
             "command": {
                 "title": "",
                 "command": "java.completion.onDidSelect",
                 "arguments": [
-                    "2",
-                    "0"
+                    "9",
+                    "25"
                 ]
             },
             "data": {
-                "pid": "0",
-                "rid": "2"
+                "pid": "25",
+                "rid": "9"
             }
-        }
+        }

The filterText for the method declaration prevents it from being filtered based on parameters. I think we should set it to be the same as method invocations.

Also, I noticed invocation are sorted in reverse order relative to declarations ? Though this may be another long-standing issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants