Skip to content

Cache and re-use type bindings for a completion invocation #2535

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 4, 2023
Merged

Cache and re-use type bindings for a completion invocation #2535

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion ...org/eclipse/jdt/ls/core/internal/contentassist/CompletionProposalReplacementProvider.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,6 +97,8 @@ public class CompletionProposalReplacementProvider {
*/
private boolean isResolvingRequest;

final Map<String, IBinding> bindings = new HashMap<>();

public CompletionProposalReplacementProvider(ICompilationUnit compilationUnit, CompletionContext context, int offset,
Preferences preferences, ClientPreferences clientPrefs, boolean isResolvingRequest) {
super();
Expand Down Expand Up @@ -937,13 +939,16 @@ private ITypeBinding getExpectedTypeForGenericParameters() {
for (int i= 0; i < keys.length; i++) {
keys[i]= String.valueOf(chKeys[0]);
}
// https://github.com/eclipse/eclipse.jdt.ls/pull/2535
if (bindings.size() > 0) {
return (ITypeBinding) bindings.get(keys[0]);
}

final ASTParser parser = ASTParser.newParser(IASTSharedValues.SHARED_AST_LEVEL);
parser.setProject(compilationUnit.getJavaProject());
parser.setResolveBindings(true);
parser.setStatementsRecovery(true);

final Map<String, IBinding> bindings= new HashMap<>();
ASTRequestor requestor= new ASTRequestor() {
@Override
public void acceptBinding(String bindingKey, IBinding binding) {
Expand Down