Set default severity of "Circular classpath" to warning
#2170
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Shi Chen [email protected]
Signed-off-by: Shi Chen <[email protected]>
CsCherrYY
requested review from
snjeza,
jdneo,
testforstephen,
Eskibear,
fbricon and
rgrunber
snjeza
approved these changes
Jul 21, 2022
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Shi Chen [email protected]
This is a workaround about redhat-developer/vscode-java#718, eclipse-buildship/buildship#460
We observed a lot of projects (especially Gradle projects) have this error. Actually, we have a workaround to set the severity to
warningmanually: eclipse-buildship/buildship#460 (comment)But for VS Code users, there is no existing wizard to config this setting and it's also hard and not recommended to change .prefs file in
.settingsfolder. In this way, we can make the default value of config towarningto make the users not be blocked by this error at least.For example, given a sample project https://github.com/opensearch-project/OpenSearch.git, the redhat.java extension reports circular dependency found in the project and the project can't be built. If we set this severity to
warning, we can only find some errors in RestTestFromSnippetsTaskTests.java (due to Java/Groovy polyglot project, which is not supported yet) and the project can be built.