Skip to content

Update TP to I20220216-0600 #2009

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 17, 2022
Merged

Update TP to I20220216-0600 #2009

merged 1 commit into from
Feb 17, 2022

Conversation

snjeza
Copy link
Contributor

@snjeza snjeza commented Feb 16, 2022

Fixes #1899

Related eclipse bug: https://bugs.eclipse.org/bugs/show_bug.cgi?id=576482
I have had to disable the lombok agent because of failing some tests. See #1782
You can reproduce it using the following command:

./mvnw clean verify -Djdt.ls.lombok.enabled=true

I think the issue in lombok is caused by http://git.eclipse.org/c/jdt/eclipse.jdt.ui.git/commit/?id=64a3b5b9cfb663e786ba9a9ad3f8deddc3c85ea2 (https://bugs.eclipse.org/bugs/show_bug.cgi?id=5753300)
I can't reproduce it in VS Code because ClientPreferences.isResolveCodeActionSupported() returns true (it is false in the tests)

Signed-off-by: Snjezana Peco [email protected]

@rgrunber
Copy link
Contributor

Overall I'm fine with this. @snjeza , can you confirm this is the error we're talking about :

stacktrace
Exception Details:
  Location:
    org/eclipse/jdt/internal/corext/dom/LinkedNodeFinder.findByNode(Lorg/eclipse/jdt/core/dom/ASTNode;Lorg/eclipse/jdt/core/dom/Name;)[Lorg/eclipse/jdt/core/dom/Name; @11: invokestatic
  Reason:
    Type '[Lorg/eclipse/jdt/core/dom/Name;' (current frame, stack[0]) is not assignable to '[Lorg/eclipse/jdt/core/dom/SimpleName;'
  Current Frame:
    bci: @11
    flags: { }
    locals: { 'org/eclipse/jdt/core/dom/ASTNode', 'org/eclipse/jdt/core/dom/Name', '[Lorg/eclipse/jdt/core/dom/Name;' }
    stack: { '[Lorg/eclipse/jdt/core/dom/Name;' }

LinkedNodeFinder has :
public static SimpleName[] findByNode(ASTNode root, SimpleName name)
public static Name[] findByNode(ASTNode root, Name name)

so is this just a bug in Lombok itself ?

@snjeza
Copy link
Contributor Author

snjeza commented Feb 17, 2022

can you confirm this is the error we're talking about :

Yes, I can.

@rgrunber
Copy link
Contributor

can you confirm this is the error we're talking about :

Yes, I can.

And it's a bug in Lombok ?

@snjeza snjeza merged commit 7483b0f into eclipse-jdtls:master Feb 17, 2022
@snjeza snjeza deleted the issue-1899 branch February 17, 2022 20:23
@snjeza snjeza mentioned this pull request Apr 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add setting for code actions to not generate comments
2 participants