Organize imports generates duplicate static import statement #1814
Conversation
|
Thanks. I'll try to have a look at this today. |
There was a problem hiding this comment.
What about the case where an existing import is on-demand (eg. import static org.hamcrest.MatcherAssert.*; ) . The favourite will still get inserted. You may have to check if any of the favourite imports match an existing on-demand one.
UPDATE : My guess is this might involve using SimpleNode#resolveBinding() ? (See OrganizeImportsOperation#addStaticImports(..)) If the method reference can be resolved (which actually happens higher up in the code) then there's no need to add another import for it.
| IImportDeclaration[] iImportDeclarations = unit.getImports(); | ||
| for (IImportDeclaration importDeclaration : iImportDeclarations) { | ||
| String elementName = importDeclaration.getElementName(); | ||
| int lastDot = elementName.lastIndexOf('.'); |
There was a problem hiding this comment.
I'd probably use Signature.getSimpleName(elementName) assuming it does exactly what you need.
Signed-off-by: Snjezana Peco <[email protected]>
Fixed. |
Fixes redhat-developer/vscode-java#2012
Signed-off-by: Snjezana Peco [email protected]