quickfix not available where cursor lands by default on annotations #1812
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rgrunber
requested changes
Jul 5, 2021
|
@rgrunber I have updated the PR. |
|
The issue seems fixed for regular spaces between eg. I think the problem is in WorkspaceDiagnosticsHandler#convertRange(..). The marker attribute's line number (based off the position of the type) is used for the starting range, but if the |
|
@rgrunber I have updated the PR. |
rgrunber
reviewed
Jul 7, 2021
...clipse.jdt.ls.core/src/org/eclipse/jdt/ls/core/internal/handlers/BaseDiagnosticsHandler.java
Outdated
Show resolved
Hide resolved
...e.jdt.ls.core/src/org/eclipse/jdt/ls/core/internal/handlers/WorkspaceDiagnosticsHandler.java
Outdated
Show resolved
Hide resolved
...e.jdt.ls.core/src/org/eclipse/jdt/ls/core/internal/handlers/WorkspaceDiagnosticsHandler.java
Outdated
Show resolved
Hide resolved
...e.jdt.ls.core/src/org/eclipse/jdt/ls/core/internal/handlers/WorkspaceDiagnosticsHandler.java
Outdated
Show resolved
Hide resolved
org.eclipse.jdt.ls.core/src/org/eclipse/jdt/ls/core/internal/JDTUtils.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Snjezana Peco <[email protected]>
|
@rgrunber I have updated the PR. |
rgrunber
approved these changes
Jul 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes redhat-developer/vscode-java#1992
Signed-off-by: Snjezana Peco [email protected]