Skip to content

Throw LSPException when no Java support can be provided #65

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
fbricon opened this issue Sep 14, 2016 · 3 comments
Closed

Throw LSPException when no Java support can be provided #65

fbricon opened this issue Sep 14, 2016 · 3 comments
Assignees
@fbricon
Milestone
Late September 2016

Comments

@fbricon
Copy link
Contributor

fbricon commented Sep 14, 2016

send connection.sendStatus(ServiceStatus.Error, msg) in InitHandler.triggerInitialization
@fbricon fbricon added this to the September 2016 milestone Sep 14, 2016
@fbricon
Copy link
Contributor Author

fbricon commented Sep 14, 2016

@gorkem it'll depend on #61 being applied

@fbricon
Copy link
Contributor Author

fbricon commented Sep 14, 2016

This is how it looks in vscode:
unsupported-java

fbricon added a commit to fbricon/eclipse.jdt.ls that referenced this issue Sep 14, 2016
@fbricon
Fix eclipse-jdtls#65 return error code when opening unsupported project
d0866d4 
Signed-off-by: Fred Bricon <[email protected]>
@fbricon fbricon self-assigned this Sep 14, 2016
@gorkem
Copy link
Contributor

gorkem commented Sep 15, 2016

Much better than the earlier silent failure.

fbricon added a commit to fbricon/eclipse.jdt.ls that referenced this issue Sep 15, 2016
@fbricon
Fix eclipse-jdtls#65 return error code when opening unsupported project
c8b285a 
Signed-off-by: Fred Bricon <[email protected]>
yaohaizh pushed a commit to yaohaizh/eclipse.jdt.ls that referenced this issue Jul 4, 2017
@fbricon
Fix eclipse-jdtls#65 add support for JDK_HOME (eclipse-jdtls#66)
810cc60 
Signed-off-by: Fred Bricon <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fbricon fbricon

Labels
None yet
Projects
None yet
Milestone
Late September 2016
Development

No branches or pull requests
2 participants
@gorkem @fbricon