Skip to content

[#711] Do not set default log level trace in cargo #712

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 30, 2025

Conversation

elfenpiff
Copy link
Contributor

@elfenpiff elfenpiff commented Apr 30, 2025

Notes for Reviewer

Pre-Review Checklist for the PR Author

  • Add sensible notes for the reviewer
  • PR title is short, expressive and meaningful
  • Consider switching the PR to a draft (Convert to draft)
    • as draft PR, the CI will be skipped for pushes
  • Relevant issues are linked in the References section
  • Every source code file has a copyright header with SPDX-License-Identifier: Apache-2.0 OR MIT
  • Branch follows the naming format (iox2-123-introduce-posix-ipc-example)
  • Commits messages are according to this guideline
  • Tests follow the best practice for testing
  • Changelog updated in the unreleased section including API breaking changes
  • Assign PR to reviewer
  • All checks have passed (except task-list-completed)

Checklist for the PR Reviewer

  • Commits are properly organized and messages are according to the guideline
  • Unit tests have been written for new behavior
  • Public API is documented
  • PR title describes the changes

Post-review Checklist for the PR Author

  • All open points are addressed and tracked via issues

References

Closes #711

@elfenpiff elfenpiff force-pushed the iox2-711-fix-set-log-level branch from c6c3209 to 1f00527 Compare April 30, 2025 09:15
@elfenpiff elfenpiff self-assigned this Apr 30, 2025
@elBoberido
Copy link
Member

@elfenpiff are you sure about this? I remember discussions where you argued in favor of having trace as default log level. I thought this would be a good middleground, trace for iceoryx devs and something less chatty for the users.

But it's also a bit inconsistent since it's only set for cargo and the C andd C++ examples do not behave the same. What do you think about adding an iceoryx dev FAQ to suggest adding this env variable to the profile?

@elfenpiff elfenpiff merged commit 08c189d into eclipse-iceoryx:main Apr 30, 2025
51 of 52 checks passed
@elfenpiff elfenpiff deleted the iox2-711-fix-set-log-level branch April 30, 2025 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

set_log_level_from_env_or Uses always LogLevel::Trace
2 participants