-
Notifications
You must be signed in to change notification settings - Fork 57
[#602] enforce that payload and header types implement ZeroCopySend #684
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#602] enforce that payload and header types implement ZeroCopySend #684
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 45 out of 47 changed files in this pull request and generated no comments.
Files not reviewed (2)
- examples/rust/BUILD.bazel: Language not supported
- examples/rust/complex_data_types/BUILD.bazel: Language not supported
Comments suppressed due to low confidence (1)
iceoryx2-bb/container/src/queue.rs:262
- [nitpick] Consider adding an inline comment explaining the safety guarantees required for this unsafe impl of ZeroCopySend for MetaQueue to clarify why it is safe.
unsafe impl<T: ZeroCopySend> ZeroCopySend for MetaQueue<T, GenericRelocatablePointer> {}
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, cant wait to merge it!
Only some minor findings.
e942e2f
to
13e4f26
Compare
73d1463
into
eclipse-iceoryx:main
Notes for Reviewer
This PR adds the requirement that every payload and header type must implement
ZeroCopySend
and adds the helper attributetype_name
to theZeroCopySend
derive macro so that a type name can be set when using the macro.Pre-Review Checklist for the PR Author
Convert to draft
)SPDX-License-Identifier: Apache-2.0 OR MIT
iox2-123-introduce-posix-ipc-example
)[#123] Add posix ipc example
)task-list-completed
)Checklist for the PR Reviewer
Post-review Checklist for the PR Author
References
Closes #602