-
Notifications
You must be signed in to change notification settings - Fork 62
[#460] Add dev_permission flag to bazel #467
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#460] Add dev_permission flag to bazel #467
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #467 +/- ##
==========================================
- Coverage 79.21% 79.12% -0.09%
==========================================
Files 196 196
Lines 23538 23538
==========================================
- Hits 18646 18625 -21
- Misses 4892 4913 +21 |
a12936a
to
fb759bb
Compare
doc/bazel/README.md
Outdated
### Feature Flags | ||
|
||
iceoryx2 provides several feature flags that can be configured using bazel | ||
build options.These flags allow you to enable or disable specific features |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
build options.These flags allow you to enable or disable specific features | |
build options. These flags allow you to enable or disable specific features |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also some other issues the linter would catch. Did you install an auto-formatter?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it part of a git hook?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@elBoberido No but am not so sure if it is a good idea for that. Ideally the auto-corrections should be verified quickly (either with a git diff or in-editor with an auto formatter). There is this script the fixing from the terminal: https://github.com/eclipse-iceoryx/iceoryx2/blob/main/internal/scripts/check_markdown_linting.sh
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@orecham I know that script but forgot to run it. I'll create a git hook to run it on all markdown files in the commit if the markdown linter is available. That should be fairly fast and catches the issues immediately for regular contributors.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@elBoberido If you want to do that, the script should already take care of finding the files on the current branch (including those not committed), so the hook would only need to run the script.
The hesitation I have is the time it takes (could be too long for a hook) and the line length correction which can mess up some intentional formatting.
Feel free to change the script however you want though.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The hook would only do the check, not perform any changes. That would be up to the developer to trigger.
fb759bb
to
8cc757b
Compare
8cc757b
to
2d27b26
Compare
Notes for Reviewer
iceoryx2
dev_permissions
feature flag has been added, allowing all processes access to all shared memory objects to allow usage in the docker environmentdev_permissions
feature flag to thebazel
buildPre-Review Checklist for the PR Author
SPDX-License-Identifier: Apache-2.0 OR MIT
iox2-123-introduce-posix-ipc-example
)[#123] Add posix ipc example
)task-list-completed
)Checklist for the PR Reviewer
Post-review Checklist for the PR Author
References
Relates to #460