-
Notifications
You must be signed in to change notification settings - Fork 62
[#464] c api #466
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#464] c api #466
Conversation
06bc9d0
to
6dcd0c6
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #466 +/- ##
==========================================
- Coverage 79.00% 78.90% -0.10%
==========================================
Files 197 198 +1
Lines 23637 23650 +13
==========================================
- Hits 18674 18662 -12
- Misses 4963 4988 +25
|
bc06605
to
98e1f21
Compare
98e1f21
to
77f4230
Compare
c94ee67
to
f013c66
Compare
log(LogLevel::Trace, "hello", "world"); | ||
log(LogLevel::Debug, "goodbye", "hypnotoad"); | ||
log(LogLevel::Info, "Who is looking for freedom?", "The Hoff!"); | ||
log(LogLevel::Warn, "Blümchen", "Bassface"); | ||
log(LogLevel::Error, "Blümchen should record a single with", "The almighty Hypnotoad"); | ||
log(LogLevel::Fatal, "It is the end", "my beloved toad."); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wouldn't it make sense to just use the iceoryx1 logging mechanism and forward the messages to the Rust logger?
We would basically get lazy evaluation for free and also logging complex messages without having to stringify it first.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We have to talk about this. I lean to prefer that we have one single mechanism and that in the future - iceoryx2_hoofs would then also use it.
But the lazy evaluation and the existing infrastructure is a strong argument to not dismiss what we already have.
Maybe we can merge both of them together ...
8e52c4e
to
f7f7e73
Compare
f7f7e73
to
4f105f3
Compare
Notes for Reviewer
log
.Logger
trait for custom loggers toLog
to be more in line with the Rust naming scheme - traits are verbsPre-Review Checklist for the PR Author
SPDX-License-Identifier: Apache-2.0 OR MIT
iox2-123-introduce-posix-ipc-example
)[#123] Add posix ipc example
)task-list-completed
)Checklist for the PR Reviewer
Post-review Checklist for the PR Author
References
Relates to #464