Skip to content

[#213]: tests methods of MessageTypeDetails #455

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

xieyuschen
Copy link
Contributor

@xieyuschen xieyuschen commented Oct 9, 2024

Notes for Reviewer

Pre-Review Checklist for the PR Author

  1. Add sensible notes for the reviewer
  2. PR title is short, expressive and meaningful
  3. Relevant issues are linked in the References section
  4. Every source code file has a copyright header with SPDX-License-Identifier: Apache-2.0 OR MIT
  5. Branch follows the naming format (iox2-123-introduce-posix-ipc-example)
  6. Commits messages are according to this guideline
  7. Tests follow the best practice for testing
  8. Changelog updated in the unreleased section including API breaking changes
  9. Assign PR to reviewer
  10. All checks have passed (except task-list-completed)

Checklist for the PR Reviewer

  • Commits are properly organized and messages are according to the guideline
  • Unit tests have been written for new behavior
  • Public API is documented
  • PR title describes the changes

Post-review Checklist for the PR Author

  1. All open points are addressed and tracked via issues

References

Updates #213

@xieyuschen xieyuschen marked this pull request as ready for review October 9, 2024 13:55
Copy link

codecov bot commented Oct 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.18%. Comparing base (ca22976) to head (88aba3d).
Report is 4 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #455      +/-   ##
==========================================
+ Coverage   78.94%   79.18%   +0.23%     
==========================================
  Files         196      196              
  Lines       23373    23540     +167     
==========================================
+ Hits        18451    18639     +188     
+ Misses       4922     4901      -21     
Files with missing lines Coverage Δ
.../src/service/static_config/message_type_details.rs 100.00% <100.00%> (ø)
...yx2/src/service/static_config/messaging_pattern.rs 92.30% <100.00%> (+18.39%) ⬆️

... and 7 files with indirect coverage changes

@xieyuschen
Copy link
Contributor Author

@elfenpiff @elBoberido i don't have the permission to assign the reviewer:( so at you directly

Copy link
Contributor

@elfenpiff elfenpiff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just split the one test case up into several ones and we are good to merge!

@xieyuschen
Copy link
Contributor Author

Just split the one test case up into several ones and we are good to merge!

cheers! @elfenpiff

@orecham
Copy link
Contributor

orecham commented Oct 10, 2024

@xieyuschen Could you add [#213] to the commit message split the big test_is_compatible_to into small tests

Not sure why the preflight-check didn't catch this 🤔

@xieyuschen xieyuschen force-pushed the iox2-213-test-cases-for-static-config branch from fa7e803 to 64fe776 Compare October 10, 2024 11:10
@xieyuschen
Copy link
Contributor Author

xieyuschen commented Oct 10, 2024

@xieyuschen Could you add [#213] to the commit message split the big test_is_compatible_to into small tests

Not sure why the preflight-check didn't catch this 🤔

done, thanks for reminding.

added on at 21:29: not sure why the pipeline failed so gamend and pushed it again to make the pipeline happy.

@xieyuschen xieyuschen force-pushed the iox2-213-test-cases-for-static-config branch from 64fe776 to 88aba3d Compare October 10, 2024 13:29
@xieyuschen
Copy link
Contributor Author

@elfenpiff @orecham looks like the macos pipeline is a bit unstable and it failed to setup rust. The other pipelines passed.

Copy link
Contributor

@elfenpiff elfenpiff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@xieyuschen again, thanks for the work you have done here.

@elfenpiff
Copy link
Contributor

@xieyuschen The next iceoryx community meetup is online on the 5th of November: https://github.com/eclipse-iceoryx/iceoryx/wiki/2024-11-05-Eclipse-iceoryx-developer-meetup

It would be nice to get to know you there. I know it is still a while, but you already committed some great contributions so it would be a pleasure to get to know you in person if you like. Also we could discuss if you would be interested in driving a feature from our roadmap - something that might interest you or you always wanted to try.

Great to have you on board!

@elfenpiff elfenpiff merged commit a684249 into eclipse-iceoryx:main Oct 10, 2024
54 of 55 checks passed
@xieyuschen
Copy link
Contributor Author

@xieyuschen The next iceoryx community meetup is online on the 5th of November: https://github.com/eclipse-iceoryx/iceoryx/wiki/2024-11-05-Eclipse-iceoryx-developer-meetup

It would be nice to get to know you there. I know it is still a while, but you already committed some great contributions so it would be a pleasure to get to know you in person if you like. Also we could discuss if you would be interested in driving a feature from our roadmap - something that might interest you or you always wanted to try.

Great to have you on board!

cool, I'm looking forward to meeting you guys in the meeting and learning more about future plans.

@xieyuschen xieyuschen deleted the iox2-213-test-cases-for-static-config branch October 11, 2024 02:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants