-
Notifications
You must be signed in to change notification settings - Fork 62
[#213]: tests methods of MessageTypeDetails #455
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#213]: tests methods of MessageTypeDetails #455
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #455 +/- ##
==========================================
+ Coverage 78.94% 79.18% +0.23%
==========================================
Files 196 196
Lines 23373 23540 +167
==========================================
+ Hits 18451 18639 +188
+ Misses 4922 4901 -21
|
@elfenpiff @elBoberido i don't have the permission to assign the reviewer:( so at you directly |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just split the one test case up into several ones and we are good to merge!
cheers! @elfenpiff |
@xieyuschen Could you add Not sure why the preflight-check didn't catch this 🤔 |
fa7e803
to
64fe776
Compare
done, thanks for reminding. added on at 21:29: not sure why the pipeline failed so gamend and pushed it again to make the pipeline happy. |
64fe776
to
88aba3d
Compare
@elfenpiff @orecham looks like the macos pipeline is a bit unstable and it failed to setup rust. The other pipelines passed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@xieyuschen again, thanks for the work you have done here.
@xieyuschen The next iceoryx community meetup is online on the 5th of November: https://github.com/eclipse-iceoryx/iceoryx/wiki/2024-11-05-Eclipse-iceoryx-developer-meetup It would be nice to get to know you there. I know it is still a while, but you already committed some great contributions so it would be a pleasure to get to know you in person if you like. Also we could discuss if you would be interested in driving a feature from our roadmap - something that might interest you or you always wanted to try. Great to have you on board! |
cool, I'm looking forward to meeting you guys in the meeting and learning more about future plans. |
Notes for Reviewer
Pre-Review Checklist for the PR Author
SPDX-License-Identifier: Apache-2.0 OR MIT
iox2-123-introduce-posix-ipc-example
)[#123] Add posix ipc example
)task-list-completed
)Checklist for the PR Reviewer
Post-review Checklist for the PR Author
References
Updates #213